Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1295230 (hawaii-workspace)
| Summary: | Review Request: hawaii-workspace - Hawaii workspace, applications and plugins | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pier Luigi Fiorini <pierluigi.fiorini> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lkundrak, package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-01-23 04:42:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 928937 | ||
|
Description
Pier Luigi Fiorini
2016-01-03 19:54:04 UTC
plfiorini's scratch build of hawaii-workspace-0.5.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12432693 naming: ok
sources: ok
8e29d8d69bf6ffe04177ad0907f395ff hawaii-workspace-0.5.0.tar.xz
licensing: ok
files: ok, but
1. the filelist is small, so SHOULD track files more closely instead of using globs everywhere, with something like:
%files
...
%{_bindir}/hawaii-polkit-agent
%{_bindir}/hawaii-screenshot
%{_sysconfdir}/xdg/hawaii-polkit-agent.desktop
%{_datadir}/applications/org.hawaiios.screenshot.desktop
2. MUST validate all application .desktop files, adding
BuildRequires: desktop-file-utils
...
%check
desktop-file-validate %{buildroot}%{_datadir}/applications/org.hawaiios.screenshot.desktop
3. SHOULD omit deprecated rpm tags
Group:
All in all, pretty simple and clean, only one mostly-cosmetic MUST blocker (2)... I'll leave it to you to add prior to doing any official builds.
APPROVED.
> 1. the filelist is small, so SHOULD track files more closely instead of using globs everywhere, with something like: Done > 2. MUST validate all application .desktop files, adding Done > 3. SHOULD omit deprecated rpm tags > Group: Done, removed the Group tag Updated the spec and srpm Spec URL: https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/take2/hawaii-workspace.spec SRPM URL: https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/take2/hawaii-workspace-0.5.0-1.fc23.src.rpm plfiorini's scratch build of hawaii-workspace-0.5.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12570615 Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/hawaii-workspace |