Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1295231 (hawaii-system-preferences)
| Summary: | Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pier Luigi Fiorini <pierluigi.fiorini> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-01-24 19:16:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 928937 | ||
|
Description
Pier Luigi Fiorini
2016-01-03 20:14:16 UTC
plfiorini's scratch build of hawaii-system-preferences-0.5.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12432770 With mixed licesing, you should provide a description in a comment in the spec file.
-n %{name}-%{version} is the default for %setup.
Spec file looks nice.
+ latest version + license is acceptable + license files are present, %license is used - I'm not convinced that the license is specified correctly + provides and requires look sane + no scriptlets present or necessary + description and name are OK Appdata file is not present, but I don't think it makes much sense to include it: this package will be installed as part of the desktop, and is useless otherwise. There is a desktop file, maybe add %check desktop-file-validate ... ? More of an upstream issue, please notify developers: DISPLAY= /usr/bin/hawaii-system-preferences QXcbConnection: Could not connect to display Aborted (core dumped) So the only notable issue is the licensing. Can you clarify which parts in the binary rpm are under which licenses? License: Executable is GPL2+, preference applets are LGPL2.1+. Appdata: I didn't include it because it might be useless for other people. Actually I can check what gnome-control-center and systemsettings do. Desktop files: yes there are a bunch of desktop files, will add validation with the next iteration. Upstream issue: Yeah looks like a Qt issue, happens with other programs too. (In reply to Pier Luigi Fiorini from comment #4) > License: Executable is GPL2+, preference applets are LGPL2.1+. OK. Please add a comment in the spec file. > Appdata: I didn't include it because it might be useless for other people. Right. That's what I said ;) > Actually I can check what gnome-control-center and systemsettings do. OK. Hm, gnome-control-center does have an appdata file. But gnome-software refuses to show it. It also fails validation. I'm not sure what the proper resolution is here. You might want to ask on fedora-devel. Either way, the package can go in without appdata. Update: - License comment - Desktop file validation - Less globs Spec URL: https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/take2/hawaii-system-preferences.spec SRPM URL: https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/take2/hawaii-system-preferences-0.5.0-1.fc23.src.rpm plfiorini's scratch build of hawaii-system-preferences-0.5.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12667586 OK, no more issues. Package is APPROVED. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/hawaii-system-preferences |