Bug 1308011

Created attachment 1126093 [details]
build.log

Created attachment 1126094 [details]
root.log

Created attachment 1126095 [details]
state.log

This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

I will fix this!

Created attachment 1144773 [details]
Update to 1.0.5 to fix test suite for Ruby 2.3 compatibility

I fixed the test suite issue.
Its test suite issue is happened with dependency package: minitest (>= 5.6.0).

So, I updated capybara_minitest_spec to latest version: 1.0.5 at first.
And created one patch file for the modification that is on master branch in upstream, but not affected to latest version.

f24 test suite had been failed because of minitest: v5.8.4
f23 test suite had been succeeded because of minitest: v5.4.3

files doc section
gemfiles is added at capybara_minitest_spec v1.0.5
HISTORY.md is deleted at capybara_minitest_spec v1.0.5

I also checked the spec file by rpmlint.

Could you my attachment file?
Thanks.

Sorry additional information.
I suggested to update this package's version.
and the dependency is also ok. We do not need to consider other packages to update this package's version.

+ dnf repoquery --enablerepo=rawhide --whatrequires 'rubygem(capybara_minitest_spec)'
  => no result

+ dnf repoquery --enablerepo=rawhide --whatrequires 'rubygem-capybara_minitest_spec'
rubygem-capybara_minitest_spec-doc-0:1.0.3-2.fc23.noarch

+ dnf repoquery --enablerepo=rawhide-source --arch src --whatrequires 'rubygem(capybara_minitest_spec)'
  => no result

+ dnf repoquery --enablerepo=rawhide-source --arch src --whatrequires 'rubygem-capybara_minitest_spec'
  => no result

The update and patch look good.

Just one thing: in the -doc subpackage, there is an empty 'gemfiles/' directory. I would rather exclude it, by

```
%exclude %{gem_instdir}/gemfiles
```

The directory is empty, because, the file 'gemfiles/Gemfile_minitest_4' is deleted by the patch fixing the test suite.

Hi, Pavel
Thanks for the review.

Is the directory empty? I could see 'gemfiles/Gemfile_minitest_4' in my environment.
Could you tell me the detail you check it?

$ rpm2cpio rubygem-capybara_minitest_spec-doc-1.0.5-1.fc25.noarch.rpm | cpio -idmv
$ ls usr/share/gems/gems/capybara_minitest_spec-1.0.5/gemfiles/
Gemfile_minitest_4

jaruga's rubygem-capybara_minitest_spec-1.0.5-1.fc25 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=753363

rubygem-capybara_minitest_spec-1.0.5-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-70cff4cb98

As a note, after discussing with him, below thing was his misunderstanding. as the patch was run in only check section.

So, we agreed regarding keeping below "gemfiles" line.

(In reply to Pavel Valena from comment #8)
> The update and patch look good.
> 
> Just one thing: in the -doc subpackage, there is an empty 'gemfiles/'
> directory. I would rather exclude it, by
> 
> ```
> %exclude %{gem_instdir}/gemfiles
> ```
> 
> The directory is empty, because, the file 'gemfiles/Gemfile_minitest_4' is
> deleted by the patch fixing the test suite.

rubygem-capybara_minitest_spec-1.0.5-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-70cff4cb98

As a note, I changed my comment in rubygem-capybara_minitest_spec.spec, from my uploaded patch, to simplify the comment.

Before
# To fix a test with minitest >= 5.6.0
# git clone https://github.com/ordinaryzelig/capybara_minitest_spec.git
# cd capybara_minitest_spec
# git format-patch -1 5e757d6c8b4e9f8d138118becdfee013acebdaa5 --stdout \
#   > rubygem-capybara_minitest_spec-1.0.5-fix-test-with-minitest-5.6-more.patch

=>

After
# https://github.com/ordinaryzelig/capybara_minitest_spec/commit/5e757d6c8b4e9f8d138118becdfee013acebdaa5.patch

rubygem-capybara_minitest_spec-1.0.5-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.