Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1312323
| Summary: | python-django-select2: Provide a Python 3 subpackage | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomas Orsava <torsava> | ||||||
| Component: | python-django-select2 | Assignee: | Eduardo Echeverria <echevemaster> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 25 | CC: | dkrejci, echevemaster, jberan, lbalhar, mhroncok | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | python-django-select2-5.8.9-1.fc26 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-09-07 11:20:00 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1285816, 1333770 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tomas Orsava
2016-02-26 12:36:57 UTC
Hi Eduardo, Do you need any help adding Python 3 support to the RPM? If you need more instructions, a [guide] for porting Python-based RPMs is available. [guide] http://python-rpm-porting.readthedocs.org/en/latest/index.html This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle. Changing version to '25'. Created attachment 1192204 [details]
Update to 5.8.9 version including Python 3 subpackage
The patch includes
- update to version 5.8.9
- source update
- modernized specfile with Python 3 packaging
Hi Jan!
The patch looks good, only has one minor fault: The names of the subpackages.
The package name in Fedora is "python-django-select2", so we want the two subpackages to be named "python2-django-select2" and "python3-django-select2".
However, since you used the macro %{pkgname} in naming of the subpackages, you'll actually get subpackages named "python2-Django-Select2" and "python3-Django-Select2"—notice the capitalization. (Sub)package names are case sensitive, so this isn't good.
The macro %{pkgname} is there only for identifying the sources in upstream, as upstream uses the capitalisation. For Fedora subpackages we want the name in lower case, so I suggest creating a second macro %{srcname} and using that to name the subpackages.
Created attachment 1192257 [details]
Updated spec file
Hi Tomáš,
thank you for the review. I made the corrections, and attach the updated spec file.
Hi Jan, Looks good to me! Hi Eduardo, as this is a bit of a time sensitive issue, we would really appreciate if you could take a look at the patch as soon as possible. If you are time constrained right now, I hope you won't mind if we do the review and push the changes ourselves in case you are unable. Thank you! Here's a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15348391 P.S.: Before pushing, one needs to do a fedpkg new-sources. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days |