Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1312323 - python-django-select2: Provide a Python 3 subpackage
Summary: python-django-select2: Provide a Python 3 subpackage
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-django-select2
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Eduardo Echeverria
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3 PY3PATCH-PUSH
TreeView+ depends on / blocked
 
Reported: 2016-02-26 12:36 UTC by Tomas Orsava
Modified: 2023-09-12 00:54 UTC (History)
5 users (show)

Fixed In Version: python-django-select2-5.8.9-1.fc26
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-07 11:20:00 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Update to 5.8.9 version including Python 3 subpackage (4.11 KB, patch)
2016-08-19 16:01 UTC, Jan Beran 		no flags Details | Diff
Updated spec file (4.15 KB, patch)
2016-08-19 18:08 UTC, Jan Beran 		no flags Details | Diff
Show Obsolete (1) View All

Description Tomas Orsava 2016-02-26 12:36:57 UTC 
Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's ok to do this in Rawhide only, however, it would be greatly
appreciated if you could push it to Fedora 24 as well.


If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
Comment 1 Dominika Krejčí 2016-06-28 09:51:15 UTC 
Hi Eduardo,

Do you need any help adding Python 3 support to the RPM?

If you need more instructions, a [guide] for porting Python-based RPMs is available.

[guide] http://python-rpm-porting.readthedocs.org/en/latest/index.html
Comment 2 Jan Kurik 2016-07-26 04:15:40 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.
Comment 3 Jan Beran 2016-08-19 16:01:31 UTC 
Created attachment 1192204 [details]
Update to 5.8.9 version including Python 3 subpackage

The patch includes
- update to version 5.8.9
- source update
- modernized specfile with Python 3 packaging
Comment 4 Tomas Orsava 2016-08-19 17:14:29 UTC 
Hi Jan!
The patch looks good, only has one minor fault: The names of the subpackages.

The package name in Fedora is "python-django-select2", so we want the two subpackages to be named "python2-django-select2" and "python3-django-select2".

However, since you used the macro %{pkgname} in naming of the subpackages, you'll actually get subpackages named "python2-Django-Select2" and "python3-Django-Select2"—notice the capitalization. (Sub)package names are case sensitive, so this isn't good.

The macro %{pkgname} is there only for identifying the sources in upstream, as upstream uses the capitalisation. For Fedora subpackages we want the name in lower case, so I suggest creating a second macro %{srcname} and using that to name the subpackages.
Comment 5 Jan Beran 2016-08-19 18:08:56 UTC 
Created attachment 1192257 [details]
Updated spec file

Hi Tomáš,

thank you for the review. I made the corrections, and attach the updated spec file.
Comment 6 Tomas Orsava 2016-08-22 08:36:25 UTC 
Hi Jan,
Looks good to me!
Comment 7 Tomas Orsava 2016-08-22 08:37:43 UTC 
Hi Eduardo,
as this is a bit of a time sensitive issue, we would really appreciate if you could take a look at the patch as soon as possible.
If you are time constrained right now, I hope you won't mind if we do the review and push the changes ourselves in case you are unable.

Thank you!
Comment 8 Tomas Orsava 2016-08-23 09:15:43 UTC 
Here's a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15348391

P.S.: Before pushing, one needs to do a fedpkg new-sources.
Comment 9 Red Hat Bugzilla 2023-09-12 00:54:25 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days
Note You need to log in before you can comment on or make changes to this bug.