Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1320653
Summary: | shiboken: Provide a Python 3 subpackage | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tomas Orsava <torsava> | ||||||
Component: | shiboken | Assignee: | Felix Schwarz <fschwarz> | ||||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | rawhide | CC: | cstratak, fschwarz, jreznik, orion, pviktori, rdieter, stephen, than | ||||||
Target Milestone: | --- | Keywords: | FutureFeature | ||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2018-02-13 09:18:19 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | 1308126, 1352326, 1424433 | ||||||||
Bug Blocks: | 1045780, 1322027 | ||||||||
Attachments: |
|
Description
Tomas Orsava
2016-03-23 17:19:53 UTC
Depends on your definition of "if upstream supports it". In this case, yes, there is a build option for python3, but it is not enabled by default... maybe for good reason(s). I'd rather get an answer for that first. (not that I'm authoritative, I'm not the primary maintainer) Would you check with upstream then? Fedora is slowly but inevitably moving towards Python 3, so your efforts are greatly appreciated! This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle. Changing version to '25'. (In reply to Rex Dieter from comment #1) > In this case, yes, there is a build option for python3, but it is not > enabled by default... maybe for good reason(s). I'd rather get an answer > for that first. I'm using PySide with Python 3.3-3.5 on a daily basis in production. Even though our app is not too complicated we did not see big problems. PySide (or shiboken) contains a few bugs but so far all these bugs were also present in the Python 2 version. (In reply to Tomas Orsava from comment #3) > Would you check with upstream then? Well, upstream is somewhat "dormant": The QT company is supposedly working on PySide 2 which should support QT 5 (only) but there is not much public activity visible. Anyhow I can attest that PySide works for me with Python 3. I applied for co-maintainership in the package db so hopefully I can push Python patches soon. Created attachment 1188602 [details] proposed changes to add Python 3 subpackage + 1.2.4 version bump This patch does a couple of things and I don't have enough time right now to untangle them: - resolve the FTBS failures (bug 1240001, bug 1308126) - update to latest upstream version 1.2.4 (no bug in rhbz currently) - provide a Python 3 subpackage If my request for co-maintainership for shiboken is granted I plan to commit this patch for F25+ (not sure about F24 - I'm using it on F24 so it should be pretty low risk but I'd only do so if there are specific requests from users). Created attachment 1188609 [details]
support Python 3.5 + egg_info for PySide
Ok, sorry for the noise: I intended to add attachment 1188609 [details] to bug 1045780 (PySide). Previous attachment 1188602 [details] applies to this bug. I'm still working on getting Python 3 to build but there is a failing test on ARM (and I don't have an ARMv7 system for testing). I have to check more closely what other distros are doing with that situation (OpenSuse just disables all tests which I don't like, I think Debian's solution is a bit more sophisticated). Maybe someone at #fedora-arm would be able to test/debug it? Also: https://fedoraproject.org/wiki/Test_Machine_Resources_For_Package_Maintainers (In reply to Charalampos Stratakis from comment #10) > Also: > https://fedoraproject.org/wiki/Test_Machine_Resources_For_Package_Maintainers That's helpful - I'll definitively use this to debug the issue in the next days. Ok, that was more than a few days but I have access to Fedora's ARM machines so hopefully I can figure out something. as I resolved the FTBS bug in F25+rawhide (bug 1308126), I'll try to get a Python 3 package working. I guess this will require additional work in F26 because of Python 3.6. I've put together a pull request for this: https://src.fedoraproject.org/rpms/shiboken/pull-request/2 Scratch builds: F28 - https://koji.fedoraproject.org/koji/taskinfo?taskID=24904640 EPEL7 - https://koji.fedoraproject.org/koji/taskinfo?taskID=24904641 (In reply to Orion Poplawski from comment #14) > I've put together a pull request for this: > > https://src.fedoraproject.org/rpms/shiboken/pull-request/2 Thank you very much for this. Incidentally I also updated my patches for shiboken+pyside for Python 3 two weeks ago but wanted to test it locally with some of my in-house apps for a while. Then I caught the flu last week so I could not push these. I'll to merge your changes tomorrow or latest Monday. Probably I'll add some changes of mine on top (or modify some or yours, e.g. I'd like to have the Python 3 patches split up) but that's fine. Btw: Do you have some Python 3 (or Python 2) PySide apps which you could test with some of my (to be published) patches? I only have a few Python 3 apps and I guess it is pretty easy for me to miss some bugs. I'm hoping to test with yubikey-piv-manager which is what is driving this for me. Thanks to Orion Poplawski we got this over the finish line. shiboken for F28+ now has a Python 3 package. I plan to push my Python 3 patches this week so we'll finally have a Python 3-ready PySide. See bug 1045780 for the PySide work. That is amazing news! Thank you Felix and Orion! |