Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1360284 (qt5-qtdeclarative-render2d)
| Summary: | Review Request: qt5-qtdeclarative-render2d - Render 2D QtDeclarative component | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Helio Chissini de Castro <helio> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | Rex Dieter <rdieter> |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-02-02 14:53:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 928937 | ||
|
Description
Helio Chissini de Castro
2016-07-26 11:57:55 UTC
Note that this will become obsolete with Qt 5.8, where the 2D renderer becomes part of qt5-qtdeclarative itself. Also please fix your spec URL, which gives me an error 404. The URL reflects the official URL. Packages just not moved to there yet ( will be today ) New source: SPEC URL: https://heliocastro.fedorapeople.org/qt5-qtdeclarative-render2d/qt5-qtdeclarative-render2d.spec SRPM URL: https://heliocastro.fedorapeople.org/qt5-qtdeclarative-render2d/qt5-qtdeclarative-render2d-5.7.1-1.fc25.src.rpm naming: ok
license: ok
sources: ok (for now, 5.7.1 tarballs not officially released yet)
macros: ok
scriptlets: ok
follows style/conventions of other qt5- packages
1. dir
%{_qt5_plugindir}/scenegraph/
is unowned, I'd suggest changing
%{_qt5_plugindir}/scenegraph/libsoftwarecontext.so
to
%{_qt5_plugindir}/scenegraph/
in %%files list
2. If -devel pkg is *just* for cmake files, having a separate -devel pkg is probably not needed imho. SHOULD drop -devel, and include this content in the main pkg.
And maybe add something like
Obsoletes: qt5-qtdeclarative-render2d-devel < 5.7.1-1
Provides: qt5-qtdeclarative-render2d-devel = %{version}-%{release}
if you want
APPROVED
Assigning the right approver. confirmed imported, closing |