Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1387873
Summary: | Review Request: python2-pyx - Python graphics package | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michal Ambroz <rebus> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | jamatos, mjg, package-review, rebus, zbyszek |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-05-08 14:18:59 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1286341 |
Description
Michal Ambroz
2016-10-22 21:49:38 UTC
Please note that the python2 dependency for the PyX is still used by the existing package scapy. See bug #1286341 . Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=16169386 I still think that packaging of PyX 0.12 as well as 0.14 should be in the same hands, which explains my being silent. And this submission proves my point: The python3 package is named PyX, so unless that is being renamed to python3-pyx there is no reason to name the python2 package with a different spelling from the python3 package (and from the former python2 package). Incidentally, if you go back to version 0.12.1-2 of the spec file you're not only back to a more consistent naming scheme but remove the newly introduced typoes, as well ;) Hello Michael, >The python3 package is named PyX I have used the naming in lover-case as I believe it goes best with the python package naming conventions and it has been also suggested to be like that in the bug #1286341 by Jose Matos. The python3 package actually also contains "provides" of the python3-pyx so naming this one python2-pyx is consistent with that. You actually do "import pyx" and not "import PyX" so I believe naming python module with lowercase is the right thing to do. > but remove the newly introduced typoes I beg your pardon. As a non-native speaker I am probably blind to the typoes. If you have some I am happy to fix those in a spec file. Best regards Michal Ambroz The upstream decision to move to python3 only is quite unfortunate. But what's done that's done. Adding a compat python2 package is reasonable. The name is OK, it should be lowercase, in line with current guidelines. I think you should: - add a fat warning in the %description that this is a compat package and should not be used for new stuff - drop the documentation parts from the package: documentation is useful for new stuff, and nobody should be using that - replace the useless macros like %__sed with normal calls [see https://fedoraproject.org/wiki/Packaging:Guidelines#Macros]. - use %py2_build and %py2_install The first point is "user visible", the remaining three are just cleanup, so just a suggestion. Thanks Zbysek for comments. Updated package: Spec URL: http://rebus.fedorapeople.org/SPECS/python2-pyx.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/python2-pyx-0.12.1-4.fc24.src.rpm Best regards Michal Ambroz %{!?python2_sitearch: %define python_sitearch %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} → harmless, but unnecessary Group: Applications/Publishing → not needed BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) → SHOULD NOT be used [https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections] Provides: python2-pyx → should be removed python2-pyx.src: E: description-line-too-long C WARNING: This is compat python2 package and should be used only for legacy stuff. python2-pyx.src:22: W: unversioned-explicit-provides python2-pyx python2-pyx.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 13) python2-pyx.src: W: file-size-mismatch pyxfaq.pdf = 159033, http://pyx.sourceforge.net/pyxfaq.pdf = 158776 python2-pyx.src: W: file-size-mismatch manual.pdf = 696879, http://pyx.sourceforge.net/manual.pdf = 707854 python2-pyx.src: W: invalid-url Source0: http://downloads.sourceforge.net/sourceforge/pyx/PyX-0.12.1.tar.gz HTTP Error 404: Not Found Thanks Zbysek for comments. Updated package: Spec URL: http://rebus.fedorapeople.org/SPECS/python2-pyx.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/python2-pyx-0.12.1-4.fc24.src.rpm Download of file was removed from sourceforge, switched to pypi repository. Best regards Michal Ambroz Opps - fingers faster than brain - the links should have been: Spec URL: http://rebus.fedorapeople.org/SPECS/python2-pyx.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/python2-pyx-0.12.1-5.fc24.src.rpm %python_provide should be used: https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file BuildRequires: python-devel → python2-devel [https://fedoraproject.org/wiki/Packaging:Python#BuildRequires] fedora-review says: - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1546240 bytes in 201 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation Not terribly important, but like I said, documentation could be dropped from the package. It looked much easier when José Matos <jamatos.pt> claimed in 1286341 :
> Michael if you want to submit this file for review I will approve it immediately.
:D
BTW Zbysek please can you make your mind - is or is not that Provides necessary? I have removed it on your request, now you want it back in form of macro. Please note this will build only with python2 so in my opinion having there just "Provides: python2-pyx" is the right thing. Using %python_provide is a must only in case building for multiple pythons. We do not want to end-up having there "Provides: python-pyx", because that would suggest python3, by default in f25. Best regards Michal Ambroz (In reply to Michal Ambroz from comment #12) > BTW Zbysek please can you make your mind - is or is not that Provides > necessary? > I have removed it on your request, now you want it back in form of macro. I did not request %python_provide to be removed. Comment c#10 was the first place where I mentioned it. > Please note this will build only with python2 so in my opinion having there > just "Provides: python2-pyx" is the right thing. Using %python_provide is a > must only in case building for multiple pythons. We do not want to end-up > having there "Provides: python-pyx", because that would suggest python3, by > default in f25. The goal of having %python_provide is that *now* we get Provides:python-%{name} on all python2 binary packages, and at some point in the *future*, when we want python3 packages to be installed when you ask for python-%{name}, we can do that switch automatically, just by adjusting the definition of that macro and doing a mass rebuild. Having a single or multiple subpackages doesn't really matter here. That switch hasn't happened yet, and will never happen in F25. Currently, when you ask for python-%{name}, you should get python2 version (either python2-%{name} subpackage for the ones that did the rename, or python-%{name} subpackage for the rest). So, python2-pyx should have the (automatically generated) Provides:python-pyx tag. (In reply to Michal Ambroz from comment #11) > It looked much easier when José Matos <jamatos.pt> claimed in 1286341 : > > Michael if you want to submit this file for review I will approve it immediately. > > :D Yeah, it's taking longer than expected ;) As a consolation, look at the this way: after the initial build you're unlikely to ever touch the package again. Hello Zbysek, OK thanks for your explanations. Here is the update: Spec URL: http://rebus.fedorapeople.org/SPECS/python2-pyx.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/python2-pyx-0.12.1-6.fc24.src.rpm Best regards Michal Ambroz Sorry for the delay. + package name is OK + package license is acceptable + license is specified correctly + P/R/BR look correct + builds and installs OK + fedora-review is happy rpmlint: python2-pyx.src: W: spelling-error %description -l en_US compat -> compact, combat, cowpat python2-pyx.src: W: spelling-error %description -l en_US scapy -> scary, soapy, scaly python2-pyx.src: W: spelling-error %description -l en_US pyxrc -> pyx python2-pyx.x86_64: W: spelling-error %description -l en_US compat -> compact, combat, cowpat python2-pyx.x86_64: W: spelling-error %description -l en_US scapy -> scary, soapy, scaly python2-pyx.x86_64: W: spelling-error %description -l en_US pyxrc -> pyx python2-pyx.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/pyx/data/lfs/createlfs.tex python2-pyx-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/PyX-0.12.1/pyx/font/_t1code.c python2-pyx-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/PyX-0.12.1/pyx/pykpathsea.c python2-pyx-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python2-pyx-doc/contrib/epstopng.py python2-pyx-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python2-pyx-doc/contrib/dvitype.py python2-pyx-doc.noarch: W: spurious-executable-perm /usr/share/doc/python2-pyx-doc/manual/graph.py python2-pyx-doc.noarch: W: spurious-executable-perm /usr/share/doc/python2-pyx-doc/examples/graphs/join.py python2-pyx-doc.noarch: W: spurious-executable-perm /usr/share/doc/python2-pyx-doc/manual/graph2.py python2-pyx-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python2-pyx-doc/contrib/textboxes.tex python2-pyx-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python2-pyx-doc/contrib/dviconvert.py python2-pyx-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python2-pyx-doc/contrib/imgconvert.py python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/manual/arrows.py /usr/bin/python2 python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/manual/pathstyles.py /usr/bin/python2 python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/manual/gradientname.py /usr/bin/python2 python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/manual/colorname.py /usr/bin/python2 python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/examples/3dgraphs/grid.py /usr/bin/python2 python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/examples/3dgraphs/surface.py /usr/bin/python2 python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/manual/connector.py /usr/bin/python2 python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/examples/3dgraphs/bar.py /usr/bin/python2 python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/examples/3dgraphs/color.py /usr/bin/python2 python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/contrib/callingtex.py /usr/bin/python2 python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/manual/color.py /usr/bin/python2 4 packages and 0 specfiles checked; 8 errors, 20 warnings. Nothing important. Package is APPROVED. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python2-pyx python2-pyx-0.12.1-6.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1365d500f2 python2-pyx-0.12.1-6.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6542140fc6 python2-pyx-0.12.1-6.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f47b98e3f python2-pyx-0.12.1-6.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f47b98e3f python2-pyx-0.12.1-6.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1365d500f2 python2-pyx-0.12.1-6.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6542140fc6 python2-pyx-0.12.1-6.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. python2-pyx-0.12.1-6.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. python2-pyx-0.12.1-6.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |