Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1397722
Summary: | Enable ACM, curl, openal, openjpeg, and webp plugins | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Yaakov Selkowitz <yselkowi> | ||||||
Component: | mingw-gstreamer1-plugins-bad-free | Assignee: | Marc-Andre Lureau <marcandre.lureau> | ||||||
Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 28 | CC: | fidencio, marcandre.lureau, mike, victortoso, yselkowi | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2018-03-12 13:44:21 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | 1395711, 1396748 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Yaakov Selkowitz
2016-11-23 09:13:09 UTC
Created attachment 1223078 [details]
Patch for rawhide and f25
openal support can also be enabled once mingw-openal-soft is in. For reference, gstreamer1-plugins-bad-free got support to openjpeg and webp in 1.6.1-2 (Nov 9 2015) and seems that curl was there since very beginning.. I'm fine with it. I don't follow the patches for configure.ac, I think they are meant to be upstream, no? Like adding #include <mmreg.h> to AC_INCLUDES_DEFAULT. (In reply to Victor Toso from comment #3) > I don't follow the patches for configure.ac, I think they are meant to be > upstream, no? Like adding #include <mmreg.h> to AC_INCLUDES_DEFAULT. The ACM configure test returns a false negative because MinGW msacm.h requires mmreg.h: $ cat test.c #include <windows.h> #include <msacm.h> int main(void) { return 0 ; } $ i686-w64-mingw32-gcc -c test.c In file included from test.c:2:0: /usr/i686-w64-mingw32/sys-root/mingw/include/msacm.h:11:2: error: #error MMREG.H version 142 or greater to be included first #error MMREG.H version 142 or greater to be included first This is probably upstreamable. OTOH, I'll have to look at the curl test again to see if the patch is upstreamable, or if it's mingw specific. (In reply to Yaakov Selkowitz from comment #4) > This is probably upstreamable. > > OTOH, I'll have to look at the curl test again to see if the patch is > upstreamable, or if it's mingw specific. Great :) Quick scratch-build [0], looks fine. [0] koji.fedoraproject.org/koji/taskinfo?taskID=16577635 Created attachment 1224735 [details]
Revised patch
This enables openal now that mingw-openal-soft is in rawhide.
Have you opened bugs upstream as mentioned in your reply on comment #4 ? This message is a reminder that Fedora 25 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 25. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '25'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 25 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle. Changing version to '28'. |