Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1421063 (deepin-gir-generator)
Summary: | Review Request: deepin-gir-generator - Generate static golang bindings for GObject | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | sensor.wen |
Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review, zbyszek, zebob.m |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-07-22 13:32:55 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1465889, 1421046, 1476583 |
Description
sensor.wen
2017-02-10 09:19:17 UTC
SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00586134-deepin-gir-generator/deepin-gir-generator.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00586134-deepin-gir-generator/deepin-gir-generator-1.0.1-2.fc25.src.rpm koji rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=21016422 koji F26: https://koji.fedoraproject.org/koji/taskinfo?taskID=21016428 Builds in rawhide fail with: cd src/gir-generator && go build -o /builddir/build/BUILD/go-gir-generator-1.0.1/out/gir-generator panic: runtime error: index out of range This seems to be a problem with go rather then this specific package (maybe related to the on-going mass rebuild?). rpmlint: deepin-gir-generator.src: W: spelling-error Summary(en_US) golang -> Angolan, Golan, Angola deepin-gir-generator.src: W: spelling-error %description -l en_US golang -> Angolan, Golan, Angola deepin-gir-generator.x86_64: W: spelling-error Summary(en_US) golang -> Angolan, Golan, Angola deepin-gir-generator.x86_64: W: spelling-error %description -l en_US golang -> Angolan, Golan, Angola deepin-gir-generator.x86_64: W: devel-file-in-non-devel-package /usr/share/gocode/src/gir/gio-2.0/gio.gen.c deepin-gir-generator.x86_64: W: devel-file-in-non-devel-package /usr/share/gocode/src/gir/gio-2.0/gio.gen.h deepin-gir-generator.x86_64: W: devel-file-in-non-devel-package /usr/share/gocode/src/gir/glib-2.0/glib.gen.c deepin-gir-generator.x86_64: W: devel-file-in-non-devel-package /usr/share/gocode/src/gir/glib-2.0/glib.gen.h deepin-gir-generator.x86_64: W: devel-file-in-non-devel-package /usr/share/gocode/src/gir/gobject-2.0/fix_gobject.c deepin-gir-generator.x86_64: W: devel-file-in-non-devel-package /usr/share/gocode/src/gir/gobject-2.0/gobject.gen.c deepin-gir-generator.x86_64: W: devel-file-in-non-devel-package /usr/share/gocode/src/gir/gobject-2.0/gobject.gen.h deepin-gir-generator.x86_64: W: devel-file-in-non-devel-package /usr/share/gocode/src/gir/gobject-2.0/gobject.h deepin-gir-generator.x86_64: W: devel-file-in-non-devel-package /usr/share/gocode/src/gir/gudev-1.0/gudev.gen.c deepin-gir-generator.x86_64: W: devel-file-in-non-devel-package /usr/share/gocode/src/gir/gudev-1.0/gudev.gen.h deepin-gir-generator.x86_64: W: no-manual-page-for-binary gir-generator 3 packages and 0 specfiles checked; 0 errors, 15 warnings. All false positives. + package name is OK + license is acceptable for Fedora (GPLv3) + license is specified correctly + %license macro is used + BR/R/P look OK + builds and installs OK in mock (and koji scratch, at least on F26) + no scriptlets necessary + fedora-review and rpmlint find no issues Package is APPROVED. SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00586134-deepin-gir-generator/deepin-gir-generator.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00586134-deepin-gir-generator/deepin-gir-generator-1.0.1-2.fc26.src.rpm I fixed it. It's build pass on the F26. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-gir-generator @mosquito: Could you please build this package in Koji? I fixed the ownership issue. @Robert build passed in Koji. deepin-gir-generator-1.0.1-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e8012be6c This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort. This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort. |