SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00585748-startdde/startdde.spec
SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00585748-startdde/startdde-3.1.14-1.fc25.src.rpm

Release 3.1.14

SPEC:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00586263-startdde/startdde.spec
SRPM:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00586263-startdde/startdde-3.1.14-1.fc26.src.rpm

Rebuild for fc26.

Please extend the %description somewhat: when is this daemon running, what exactly does it start, etc.

Webkitgtk is gone from rawhide. This is a big problem. Does the upstream plan to replace this with something different?

This package installs a service that is permanently enabled, and always runs when the package is installed. This should be replaced by the systemd preset mechanism [https://fedoraproject.org/wiki/Packaging:DefaultServices]. So there are two things to change:
1. in the spec file, use macros from https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd
2. after that a systemd preset can be requested as described in Packaging:DefaultServices. This case is very simple, so there should be no problem.

SPEC:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00594502-startdde/startdde.spec
SRPM:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00594502-startdde/startdde-3.1.15-1.fc26.src.rpm

Relase 3.1.15

You should remove the dependency to golang(github.com/howeyc/fsnotify) as upstream removed it from the source in:

https://github.com/linuxdeepin/startdde/commit/0b964c55bd0f01e73fb0e3a08a252da6e289c4c4

They forked it into pkg.deepin.io/lib/fsnotify


Package is okay otherwise, just fix this before import.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v3 or later)", "Unknown or generated". 35 files have
     unknown license. Detailed output of licensecheck in
     /home/bob/packaging/review/startdde/review-startdde/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/libexec/deepin-daemon
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/libexec/deepin-daemon
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     startdde-debuginfo , startdde-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.



Rpmlint
-------
Checking: startdde-3.1.15-1.fc28.x86_64.rpm
          startdde-debuginfo-3.1.15-1.fc28.x86_64.rpm
          startdde-debugsource-3.1.15-1.fc28.x86_64.rpm
          startdde-3.1.15-1.fc28.src.rpm
startdde.x86_64: W: spelling-error Summary(en_US) deepin -> deepen, deep in, deep-in
startdde.x86_64: W: spelling-error %description -l en_US xdg -> bldg
startdde.x86_64: W: spelling-error %description -l en_US autostart -> auto start, auto-start, autos tart
startdde.x86_64: W: no-manual-page-for-binary startdde
startdde-debugsource.x86_64: W: no-documentation
startdde.src: W: spelling-error Summary(en_US) deepin -> deepen, deep in, deep-in
startdde.src: W: spelling-error %description -l en_US xdg -> bldg
startdde.src: W: spelling-error %description -l en_US autostart -> auto start, auto-start, autos tart
4 packages and 0 specfiles checked; 0 errors, 8 warnings.

 https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/startdde.spec

Removed golang(github.com/howeyc/fsnotify), thanks.

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/startdde

This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.