Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1442842
Summary: | 4.8.19-2: go back to slang and other cleanups | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tomasz Kłoczko <kloczko.tomasz> | ||||||||
Component: | mc | Assignee: | Jindrich Novy <novyjindrich> | ||||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
Severity: | unspecified | Docs Contact: | |||||||||
Priority: | unspecified | ||||||||||
Version: | rawhide | CC: | alekcejk, Blaise, cheese, dvlasenk, gwync, jpokorny, mkasik, nerijus, novyjindrich, pahan, slavazanko | ||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | mc-4.8.19-2.fc26 mc-4.8.19-2.fc25 mc-4.8.19-2.fc24 | Doc Type: | If docs needed, set a value | ||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2017-05-09 21:24:36 UTC | Type: | Bug | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Bug Depends On: | |||||||||||
Bug Blocks: | 1440856 | ||||||||||
Attachments: |
|
This fix should be pushed to older Fedora versions updates as well. Could you please include this patch as well - https://mail.gnome.org/archives/mc-devel/2017-April/msg00006.html ? Without it the filestamps of files copied from tar.gz, cpio, are not preserved (see https://mail.gnome.org/archives/mc-devel/2017-April/msg00000.html). I'll busy for next 2 days. Hopefully rel 2 with reverte to use slang will be released soon because this is now more important. Will try to have look later on this. PS. I have no RW access to mc but I can help maintain it as my admin access request will be approved. Created attachment 1272765 [details]
4.8.19-2 mc.spec.patch
corrected typo.
Hellow. Can I have any feedback from maintainer? Current binary mc package has an issue which needs to be sorted out ASAP!!! any progress on this? Note that you need to use "%bcond_with ncurses" if you want to avoid ncurses by default :-) Also the use of "with_ncurses" macro may not be right. Was the build even tested? http://rpm.org/user_doc/conditional_builds.html It was tested seems you wrote your comment without testing. "%bcond_without foo" enables it. Yes, it is illogical but it works exactly this way and it works completely opposite to --with{,out} foo cmd switches. First found example abrt.spec. You can find in it %if 0%{?fedora} >= 14 %bcond_without systemd %else %bcond_with systemd %endif and as you see "%bcond_without systemd" enables by default build abrt with systemd support on fedora>=14 Because %bcond has been introduced +12 years ago now is to late to reverse how it works because it will break thousands of specs files. If the purpose is that "without ncurses" is the default, it should really be: > %bcond_with ncurses because otherwise (bcond_without), "with_ncurses" gets normally (with non-opinionated "rpmbuild" run) defined and you will end up building with ncurses, which against the intent of this bug? You should also be crafting binary either-or strings like this: > %{?with_ncurses:ncurses-devel}%{!?with_ncurses:slang-devel} Note that passing --with/--without to rpmbuild does not count, it will not get called like this in koji build. Nope, I haven't tested that myself, but I don't lack packaging experience either. [..]
> Nope, I haven't tested that myself, but I don't lack packaging
> experience either.
I'm confused a bit. So what you are doing here?
Please do this first and then try to discuss anything.
If you are not familiar with %bcond (and seems you are because you didn't know that "%bcond_without foo" enables foo) please do not ask me to elaborate how macros created by %bcond are working. RTFM.
If it is not clear this %bcond is not for automated build over koji but for developers able to diagnose ncurses ot term applications issues which mc exposes by compiling with ncurces.
Created attachment 1276446 [details]
mc.spec.patch
I must apologize Jan. He was right about my mistake in %bcond logic in my patch.
Simple I've attached incorrect version of the patch.
I've changed %bcond name to "%bcond_without slang" to make it less confusing that slang is default screen type.
No problem, glad that point was taken :) Applying patch, see FESCO ticket for background. mc-4.8.19-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0b205eabf4 mc-4.8.19-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-bf0dcd75c6 mc-4.8.19-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-70c2e0ec52 BuildRequires: %{?with_slang:slang-devel}%{!?with_slang:slang-devel} one of them should be ncurses-devel. Fixed in rawhide, will be picked up in the future. Good catch, thank you. mc-4.8.19-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-70c2e0ec52 mc-4.8.19-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0b205eabf4 mc-4.8.19-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-bf0dcd75c6 mc-4.8.19-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. mc-4.8.19-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. mc-4.8.19-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 1272123 [details] 4.8.19-2 mc.spec.patch Please review and commit spec file patch. Copy of the %changelog entry: * Mon Apr 17 2017 Tomasz Kłoczko <kloczek> - 1:4.8.19-2 - go back to slang as it is serious issue with shift-f6 when ncurses is used displaying "Delete" instead "Move As" dialog (#1436394) - reformat %%description to 80 cols - really remove Group - %%defattr() is no longer needed - simplifications in %%files - use %%{buildroot} macro - build --with-x (it does not add X11 libraries dependencies) - cons.saver no longer need to be 711 (changed to 755)