Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1480973 (golang-github-alecthomas-kingpin)

Summary: Review Request: golang-github-alecthomas-kingpin - A Go command line and flag parser
Product: [Fedora] Fedora Reporter: sensor.wen
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: athoscribeiro, package-review, zebob.m
Target Milestone: ---Flags: zebob.m: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-07-22 13:32:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1465889, 1421046, 1476589, 1476590    

Comment 1 Robert-André Mauchin 🐧 2017-08-23 14:34:11 UTC
Hello,

 - The _examples/ folder should go in %doc:

%doc _examples

And remove it from devel.file-list:

for file in $(find . -iname "*.go" \! -iname "*_test.go" \! -path "./_examples/*")  ; do


 - Change:

%dir %{gopath}/src/%{import_path}

to

%dir %{gopath}/src/%{import_path}/cmd

And remove: %{gopath}/src/%{import_path2}

(The import_path was already listed but the subdirectory cmd was not)


 - Missing dependency:

DEBUG util.py:450:  No matching package to install: 'golang(github.com/alecthomas/assert)'
→ Bug #1480971: accepted but not yet built. It seems you haven't yet requested the repo to be created with fedrepo-req. Please do it so we can move forward.

Comment 2 sensor.wen 2017-08-25 10:52:50 UTC
Diff:  https://github.com/FZUG/repo/commit/bba881590a66a510dbf653210ac5b23c96f0da0e

Fixed. the github-alecthomas-assert package is build passed, but it is not included in the rawhide. Maybe we need to wait some time.

https://src.fedoraproject.org/rpms/golang-github-alecthomas-assert

Comment 3 Robert-André Mauchin 🐧 2017-08-25 11:21:03 UTC
This is okay for me, package accepted.

Comment 4 Gwyn Ciesla 2017-08-25 13:00:34 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-kingpin

Comment 5 Athos Ribeiro 2017-10-14 19:51:53 UTC
Should this be closed?

Comment 6 Zamir SUN 2018-07-22 13:32:07 UTC
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.