SPEC:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-i386/00586047-deepin-daemon/deepin-daemon.spec
SRPM:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-i386/00586047-deepin-daemon/deepin-daemon-3.1.17-1.fc25.src.rpm

Release 3.1.17

SPEC:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00586262-deepin-daemon/deepin-daemon.spec
SRPM:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00586262-deepin-daemon/deepin-daemon-3.1.17-1.fc26.src.rpm

Rebuild for fc26.

Hello,

A couple of preliminary remarks:
 - You shouldn't request golang dependencies directly like this, but instead use a construct like: golang(import_path). See below.

 - You should not use go get …, you should add all the Golang dependencies directly to your BR. Here's the full list you need:
BuildRequires:  golang(github.com/BurntSushi/xgb)
BuildRequires:  golang(github.com/BurntSushi/xgbutil)
BuildRequires:  golang(github.com/howeyc/fsnotify)
BuildRequires:  golang(golang.org/x/image)
BuildRequires:  golang(gopkg.in/alecthomas/kingpin.v2)
BuildRequires:  golang(github.com/BurntSushi/freetype-go)
BuildRequires:  golang(github.com/BurntSushi/graphics-go)
BuildRequires:  golang(github.com/axgle/mahonia)
BuildRequires:  golang(github.com/msteinert/pam)
BuildRequires:  golang(github.com/nfnt/resize)

 - Golang is not available on all arches, thus you need an ExclusiveArch:
ExclusiveArch:  %{?go_arches:%{go_arches}}%{!?go_arches:%{ix86} x86_64 aarch64 %{arm}}

(Please update to the latest go-srpm-macros from rawhide if you do a Koji build later, otherwise it will fail on ppc64)

 - You shouldn't do BR: golang but instead:
BuildRequires:  %{?go_compiler:compiler(go-compiler)}%{!?go_compiler:golang}

 - There are numerous Golang dependencies I pulled from your COPR, but you should make Review Requests for all of them otherwise it makes it difficult to review such packages.

 - You could replace these -devel packages with pkgconfig invocation:
BuildRequires:  pkgconfig(gnome-keyring-1)
BuildRequires:  pkgconfig(libsystemd)
BuildRequires:  pkgconfig(poppler-glib)

SRPM:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00593049-deepin-daemon/deepin-daemon-3.1.18-1.fc26.src.rpm
SPEC:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00593049-deepin-daemon/deepin-daemon.spec

Thanks, i fix some problem.

The SPEC looks ok, sadly I can't yet build it because some package are not yet in Rawhide:

DEBUG util.py:450:  No matching package to install: 'deepin-gir-generator'
→ Bug #1421063 → Package approuved but not yet build? 
Strangely Gwyn is listed as the admin here https://src.fedoraproject.org/rpms/deepin-gir-generator ? Maybe a bug? Send Gwyn a message to become the main admin of your repository and then build the packages in Koji.


DEBUG util.py:450:  No matching package to install: 'deepin-go-dbus-factory'
→ Bug #1476589, not yet accepted

DEBUG util.py:450:  No matching package to install: 'golang(github.com/BurntSushi/xgbutil)'
→ Bug  #1480972: On my todo list to accept

DEBUG util.py:450:  No matching package to install: 'golang(github.com/axgle/mahonia)'
→ Bug #1480957: We need @zbyszek.pl to approuve it.

DEBUG util.py:450:  No matching package to install: 'golang(gopkg.in/alecthomas/kingpin.v2)'
→ Bug #1480973: nobody's working on it yet

DEBUG util.py:450:  No matching package to install: 'golang(pkg.deepin.io/dde/api)'
→ Bug #1476589: There's work to be done on the spec

DEBUG util.py:450:  No matching package to install: 'golang(pkg.deepin.io/lib)'
→ Bug #1421046: On my todo list

I've a mistake

DEBUG util.py:450:  No matching package to install: 'deepin-go-dbus-factory'
→ I can't find this package, have you proposed it yet?

Found it bug #1476565

Depends on deeping-grub2-theme, which I can't find. Please post a Review request for it.

deeping-grub2-theme https://bugzilla.redhat.com/show_bug.cgi?id=1485374

deeping-grub2-theme has been submitted.

SPEC:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00594503-deepin-daemon/deepin-daemon.spec
SRPM:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00594503-deepin-daemon/deepin-daemon-3.1.19-1.fc26.src.rpm

Release 3.1.19

SPEC:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00595618-deepin-daemon/deepin-daemon.spec
SRPM:  https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00595618-deepin-daemon/deepin-daemon-3.1.19-2.fc26.src.rpm

add default settings

It seems all deps are in POST state. Is anything else needed? It'd be great to build all the deps in rawhide to make the review easier.

Nah, it was on my TODO list for yesterday but I forgot about it.

Anyway I have build errors:
# pkg.deepin.io/dde/daemon/inputdevices
gopath/src/pkg.deepin.io/dde/daemon/inputdevices/wacom.go:538:11: dw.ResetArea undefined (type *dxinput.Wacom has no field or method ResetArea)
gopath/src/pkg.deepin.io/dde/daemon/inputdevices/wacom.go:548:27: dw.GetArea undefined (type *dxinput.Wacom has no field or method GetArea)
make: *** [Makefile:47: out/bin/dde-session-daemon] Error 2
make: *** Waiting for unfinished jobs....
error: Bad exit status from /var/tmp/rpm-tmp.bGqDiT (%build)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.bGqDiT (%build)
Child return code was: 1
EXCEPTION: [Error()]


After digging through the code it turns out dw.ResetArea and dw.GetArea got added in dde-api in version 3.1.13 https://github.com/linuxdeepin/dde-api/commit/cf9f07cacc8ef52f71c5d60adfa2b15616e988f0

Fortunately, mosquito has anticipated this and is currently building it Koji: https://koji.fedoraproject.org/koji/buildinfo?buildID=965297

This package is getting on my nerves, I'll look at it tomorrow.

Some dependencies (deepin-api, golang-deepin-dbus-factory) doesn't available in Rawhide. Do not worry, i try to compile them everyday.

I was tired of waiting so I built deepin-api locally.

Anyway, there's an issue, the package doesn't provide debugging symbols. It seems they have been deactivated in the Makefile. Thus you need to patch the Makefile to get the debugging symbols back. Here's my patch:

diff -up dde-daemon-3.1.19/Makefile.old dde-daemon-3.1.19/Makefile
--- dde-daemon-3.1.19/Makefile.old	2017-08-24 03:42:43.000000000 +0200
+++ dde-daemon-3.1.19/Makefile	2017-09-04 18:06:11.382062647 +0200
@@ -3,7 +3,7 @@ GOPATH_DIR = gopath
 GOPKG_PREFIX = pkg.deepin.io/dde/daemon
 
 ifndef USE_GCCGO
-	GOLDFLAGS = -ldflags '-s -w'
+	GOLDFLAGS =
 else
 	GOLDFLAGS = -s -w  -Os -O2 -mieee
 endif



 - One useful macro to avoid hardcoded directories:

/usr/lib/sysusers.d/ →→ %{_sysusersdir

 - Some directories specific to your package are unowned:

/usr/share/dde
/usr/share/deepin-default-settings
/var/cache/appearance



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
     generated", "*No copyright* Public domain", "LGPL (v3 or later)", "GPL
     (v2 or later) (with incorrect FSF address)", "*No copyright* LGPL
     (v2.1 or later)". 369 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/deepin-daemon/review-
     deepin-daemon/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /var/cache/appearance,
     /usr/share/locale/es_419, /usr/share/deepin-default-settings,
     /usr/share/locale/am_ET/LC_MESSAGES, /usr/lib/systemd/logind.conf.d,
     /usr/share/locale/am_ET, /usr/share/dde,
     /usr/share/locale/es_419/LC_MESSAGES
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/locale/am_ET/LC_MESSAGES, /usr/share/locale/am_ET,
     /usr/share/dbus-1/system-services, /usr/share/dde, /usr/share/dbus-1,
     /usr/lib/systemd/logind.conf.d, /usr/share/deepin-default-settings,
     /var/cache/appearance, /usr/share/locale/es_419,
     /usr/share/locale/es_419/LC_MESSAGES, /usr/share/dbus-1/services
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in deepin-
     daemon-debuginfo
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[-]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 2048000 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: deepin-daemon-3.1.19-2.fc28.x86_64.rpm
          deepin-daemon-debuginfo-3.1.19-2.fc28.x86_64.rpm
          deepin-daemon-3.1.19-2.fc28.src.rpm
deepin-daemon.x86_64: E: explicit-lib-dependency bluez-libs
deepin-daemon.x86_64: E: explicit-lib-dependency libudisks2
deepin-daemon.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
deepin-daemon.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
deepin-daemon.x86_64: E: incorrect-locale-subdir /usr/share/locale/es_419/LC_MESSAGES/dde-daemon.mo
deepin-daemon.x86_64: E: invalid-lc-messages-dir /usr/share/locale/es_419/LC_MESSAGES/dde-daemon.mo
deepin-daemon.x86_64: W: dangerous-command-in-%postun rm
deepin-daemon.src:111: E: hardcoded-library-path in %{buildroot}/usr/lib/sysusers.d/deepin-daemon.conf
deepin-daemon.src:114: E: hardcoded-library-path in %{buildroot}/usr/lib/systemd/logind.conf.d/
deepin-daemon.src:115: E: hardcoded-library-path in %{buildroot}/usr/lib/systemd/logind.conf.d/10-%{name}.conf
deepin-daemon.src:158: E: hardcoded-library-path in %{_prefix}/lib/sysusers.d/%{name}.conf
deepin-daemon.src:159: E: hardcoded-library-path in %{_prefix}/lib/systemd/logind.conf.d/10-%{name}.conf
3 packages and 0 specfiles checked; 9 errors, 3 warnings.

golang-deepin-dbus-factory was compile pass, but it's still not available in Rawhide. :((((((((

https://github.com/FZUG/repo/commit/954f3c43fde702900437eecc2fdb7554a08fb8c7

Fixed debug symbols

https://pagure.io/fedora-infrastructure/issue/6348

golang-deepin-dbus-factory is not available in Rawhide, so i opened a new issue to discuss it.

https://koji.fedoraproject.org/koji/taskinfo?taskID=21791640

deepin-api is build pass.

Dependency is already available. Let's keep going.

All okay, package accepted.



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
     generated", "*No copyright* Public domain", "LGPL (v3 or later)", "GPL
     (v2 or later) (with incorrect FSF address)", "*No copyright* LGPL
     (v2.1 or later)". 369 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/deepin-daemon/review-
     deepin-daemon/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/locale/es_419,
     /usr/share/locale/am_ET/LC_MESSAGES, /usr/lib/systemd/logind.conf.d,
     /usr/share/locale/am_ET, /usr/share/locale/es_419/LC_MESSAGES
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/locale/am_ET,
     /usr/share/dbus-1/system-services, /usr/share/dbus-1,
     /usr/lib/systemd/logind.conf.d, /usr/share/dbus-1/services,
     /usr/share/locale/es_419, /usr/share/locale/es_419/LC_MESSAGES,
     /usr/share/locale/am_ET/LC_MESSAGES
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in deepin-
     daemon-debuginfo
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[ ]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 2048000 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: deepin-daemon-3.1.19-2.fc28.x86_64.rpm
          deepin-daemon-debuginfo-3.1.19-2.fc28.x86_64.rpm
          deepin-daemon-3.1.19-2.fc28.src.rpm
deepin-daemon.x86_64: E: explicit-lib-dependency bluez-libs
deepin-daemon.x86_64: E: explicit-lib-dependency libudisks2
deepin-daemon.x86_64: E: incorrect-locale-subdir /usr/share/locale/es_419/LC_MESSAGES/dde-daemon.mo
deepin-daemon.x86_64: E: invalid-lc-messages-dir /usr/share/locale/es_419/LC_MESSAGES/dde-daemon.mo
deepin-daemon.x86_64: W: dangerous-command-in-%postun rm
deepin-daemon.src:109: E: hardcoded-library-path in %{buildroot}/usr/lib/sysusers.d/deepin-daemon.conf
3 packages and 0 specfiles checked; 5 errors, 1 warnings.

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-daemon

This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.