Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1495293
| Summary: | Review Request: python-Naked - A command line application framework | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | greg.hellings | ||||||
| Component: | Package Review | Assignee: | Clint Savage <csavage> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | csavage, herlo1, package-review | ||||||
| Target Milestone: | --- | Flags: | csavage:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-03-06 17:19:27 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
greg.hellings
2017-09-25 17:59:42 UTC
Created attachment 1331164 [details]
rpmlint.txt from fedora-review
rpmlint errors
rpmlint gives a really long list of errors. I reviewed them, and even built the package against mock.
- The description is definitely too long, could be trimmed.
- Maybe the non-executable-script errors should be give execution permissions?
- not sure about the wrong-script-interpreter error, maybe other wsgi apps could help?
The description was fine, but the line length was obscene. I've added line breaks and now it's recording OK. The non-executable scripts should have their spurious shebang lines removed, which I've done. It also addresses the wrong-script-interpreter issue as well. I've simply deleted the line from the top of the offending files. New spec file: https://fedorapeople.org/~greghellings/python-Naked/python-Naked.spec New SRPM: https://fedorapeople.org/~greghellings/python-Naked/python-Naked-0.1.31-2.fc27.src.rpm Created attachment 1383081 [details]
fedora-review results (review.txt) 20180118
I think all of my concerns from above were met. I noted a few nits in the attached review.txt, but nothing preventing approval. @Clint - You need to set the fedora-review flag to "+". I tried to update it myself, but the repo creation tool checks that, and won't allow me to set it on my own request (I should have realized that...). If you can set that, I can move forward with closing this one out. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-Naked. You may commit to the branch "f27" in about 10 minutes. python-Naked-0.1.31-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-472ea01f77 python-Naked-0.1.31-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-472ea01f77 python-Naked-0.1.31-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-91d06f2add python-Naked-0.1.31-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-91d06f2add python-Naked-0.1.31-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. |