Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1536782 (golang-github-cryptix-wav)
| Summary: | Review Request: golang-github-cryptix-wav - golang wav reader and writer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | sensor.wen |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zebob.m |
| Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-07-22 13:32:26 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1465889 | ||
|
Description
sensor.wen
2018-01-21 06:33:08 UTC
- add examples/ to %doc
- when you package a development snapshot, you must add the commit date in Release:
%global commit 7b3d650b50a50a0137376e392770f372edc3d968
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global commitdate 20171018
Name: golang-%{provider}-%{project}-%{repo}
Version: 0
Release: 0.1.%{commitdate}git%{shortcommit}%{?dist}
And in %changelog:
* Thu Dec 21 2017 mosquito <sensor.wen> - 0-0.1.20171018git7b3d650
SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-27-x86_64/00713241-golang-github-cryptix-wav/golang-github-cryptix-wav.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-27-x86_64/00713241-golang-github-cryptix-wav/golang-github-cryptix-wav-0-0.1.20171018git7b3d650.fc27.src.rpm I fixed it, thank you. Please review again. Tests require github.com/cheekybits/is, it would be nice to package it, and add it to the SPEC to run the tests correctly. Package otherwise approved. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-cryptix-wav This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort. This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort. |