Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1622552

Summary: Review Request: golang-github-linuxdeepin-dbus-factory - GO DBus factory for Deepin Desktop Environment
Product: [Fedora] Fedora Reporter: sensor.wen
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, robinlee.sysu, zebob.m
Target Milestone: ---Flags: zebob.m: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: golang-github-linuxdeepin-dbus-factory-0.0.7.1-1.20181114git0bb7f20.fc30 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-27 10:25:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1465889    

Comment 1 Robert-André Mauchin 🐧 2018-08-27 16:11:37 UTC
You need to use the new Go packaging method, see: https://fedoraproject.org/wiki/More_Go_packaging

You can see examples here: https://eclipseo.fedorapeople.org/golang/

You should get something like this:

===============================================================================
# https://github.com/linuxdeepin/go-dbus-factory
%global goipath         github.com/linuxdeepin/go-dbus-factory
%global commit          2a30fc6fb47b70b8879855df8e29c8f581c419aa

%gometa

Name:           %{goname}
Version:        0.0.7
Release:        1%{?dist}
Summary:        GO DBus factory for Deepin Desktop Environment
License:        GPLv3
URL:            %{gourl}
Source0:        %{gosource}

%description
%{summary}


%package devel
Summary:       %{summary}
BuildArch:     noarch

%description devel
%{summary}

This package contains library source intended for
building other packages which use import path with
%{goipath} prefix.


%prep
%forgeautosetup


%install
%goinstall


%check
%gochecks


%files devel -f devel.file-list
%doc README.md CHANGELOG.md


%changelog
* Fri Aug 10 2018 mosquito <sensor.wen> - 0.0.7-1.20180828git2a30fc6
- First package for Fedora
===============================================================================

Comment 3 Robert-André Mauchin 🐧 2018-08-27 19:16:44 UTC
Please note that the SPEC name should now be golang-github-linuxdeepin-dbus-factory.spec  The new Go packaging automatically removes "go" or "git" in package name.


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 4 sensor.wen 2018-08-27 19:29:43 UTC
OK, thank you for your help.

Comment 5 Gwyn Ciesla 2018-08-27 20:42:49 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-linuxdeepin-dbus-factory