Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165329
Summary: | Review Request: roundup | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <redhat> |
Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | gauret |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://roundup.sourceforge.net | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-09-17 23:29:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
W. Michael Petullo
2005-08-08 02:07:58 UTC
- You can use http://dl.sourceforge.net/roundup/roundup-%{version}.tar.gz in the URL tag, so it can be wget'ed directly - insead of $RPM_SOURCE_DIR/roundup.conf you should use %{SOURCE1}, same thing for %{SOURCE2} (which I would rename in roundup.init, but do as you want) - please use the -p switch of install to preserve timestamps - I'm not sure you can hardcode UID 58 for your roundup user. It could be used already on some system. Just remove it, the -r switch will create a system account anyway (100 < UID < 500) - scriptlets should never echo anything. It could crash some frontends, or simply be ignored by frontends. So: - Make sure everything goes to /dev/null with : > /dev/null 2>&1 (e.g. for roundup-admin). - Don't echo things, write a README.Fedora instead - don't delete your user on %postun, since the UID could change if the package is reinstalled and the files will be unowned. - you may want to stop the service only on erase, not on upgrade. See this page : http://fedoraproject.org/wiki/ScriptletSnippets for more info dealing with initscripts. - you can use %{_initrddir} instead of %{_sysconfdir}/rc.d/init.d (yes, the name is misleading, but it's the same) - you can use disttag if you want to. - one more thing : if you want to test for the presence of the /var/lib/roundup directory, it's the -d switch, not -f. Spec Name or Url: http://flyn.org/SRPMS/roundup.spec SRPM Name or Url: http://flyn.org/SRPMS/roundup-0.8.4-2.src.rpm Description: Roundup is a simple and flexible issue-tracking system with command line, web and email interfaces. It is based on the winning design from Ka-Ping Yee in the Software Carpentry "Track" design competition. This version finishes implementing Aurelien's recommendations by fixing the use of useradd. Spec Name or Url: http://flyn.org/SRPMS/roundup.spec SRPM Name or Url: http://flyn.org/SRPMS/roundup-0.8.4-3.src.rpm Description: Roundup is a simple and flexible issue-tracking system with command line, web and email interfaces. It is based on the winning design from Ka-Ping Yee in the Software Carpentry "Track" design competition. Bug #166451 proposes a SELinux policy for this Roundup package. * The summary is too long, please change it to "Simple and flexible issue-tracking system" * The roundup service is enabled by default. We usually don't do that with network-listening daemons, please change the "345" to "-" at the top of the init script. * man pages are placed in /usr/man instead of /usr/share/man * The lang file are not tagged properly, please use the %{find_lang} macro (those two points will prevent from using INSTALLED_FILES, sorry...) * the package should contain the text of the license (COPYING.txt) * %{_initrddir}/roundup should be tagged as %config(noreplace) because of the port setting * you could support condrestart in scriptlets: %post if [ "$1" -ge "1" ]; then /sbin/service <script> condrestart >/dev/null 2>&1 fi This version implements Aurelien's new recommendations. Spec Name or Url: http://flyn.org/SRPMS/roundup.spec SRPM Name or Url: http://flyn.org/SRPMS/roundup-0.8.4-4.src.rpm Description: Roundup is a simple and flexible issue-tracking system with command line, web and email interfaces. It is based on the winning design from Ka-Ping Yee in the Software Carpentry "Track" design competition. - the service is still enabled by default. At the top of the init script, you have to change the line: # chkconfig: 345 95 5 to : # chkconfig: - 95 5 - while you're at it, you may want to change "%{_mandir}/*" to "%{_mandir}/man1/*", or your package will own a standard dir (which is not really a problem, but it would make our friend rpmlint happier) Everything else looks fine. This time I really fixed the chkconfig: line. Spec Name or Url: http://flyn.org/SRPMS/roundup.spec SRPM Name or Url: http://flyn.org/SRPMS/roundup-0.8.4-5.src.rpm Description: Roundup is a simple and flexible issue-tracking system with command line, web and email interfaces. It is based on the winning design from Ka-Ping Yee in the Software Carpentry "Track" design competition. Passed: * RPM name is OK * Source roundup-0.8.4.tar.gz is the same as upstream * Builds fine in mock * rpmlint of roundup looks OK * File list of roundup looks OK * Seems to work fine Added roundup package to CVS and requested build. Changed summary for tracking purposes. |