Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165353
Summary: | Review Request: libtranslate - A natural language translation library | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dmitry Butskoy <dmitry> | ||||
Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | fedora-package-review | ||||
Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
URL: | http://www.nongnu.org/libtranslate | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-09-08 13:46:06 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779, 165960 | ||||||
Attachments: |
|
Description
Dmitry Butskoy
2005-08-08 14:11:08 UTC
Correct URL. Also I have added "gnome-translate" package for review, which is just a Gnome GUI for libtranslate. It is better to examine both these packages together. Fixed (provide full url): Spec Name or Url: http://dmitry.butskoy.name/libtranslate/libtranslate.spec SRPM Name or Url: http://dmitry.butskoy.name/libtranslate/libtranslate-0.99-1.src.rpm There are a couple of items I'd like you to fix before I do the formal review. I've provided a diff that implements these items: - I strongly recommend that you use the %{?dist} tag. It will help you ensure that builds for each branch do not have the same n-v-r - Get rid of all of the Requires, except libsoup >= 2.2, because rpm finds them automatically. - Devel packages should Require: %{name} = %{version}-%{release} - You need to run: rm -f $RPM_BUILD_ROOT%{_libdir}/libtranslate/modules/*.la - Your %files needs a little work. Remember, you need to own directories that you create, but not directories that already exist on the system. This means that you need to own %{_libdir}/libtranslate/ and %{_libdir}/libtranslate/modules/ and %{_includedir}/libtranslate/ ... but NOT %{_datadir}/gtk-doc/ Created attachment 117872 [details]
cleanups for libtranslate.spec
Thanks, New srpms is at http://dmitry.butskoy.name/libtranslate/libtranslate-0.99-3.src.rpm I also remove libtranslate/modules/*.a from devel package, IMHO it is not needed... An appropriate cleanups was made for gnome-translate too (bug #165960). Review: Good: - rpmlint output: E: libtranslate outside-libdir-files /usr/share/libtranslate/services.dtd Safe to ignore. - meets naming guidelines - license BSD ok, license text in %doc, matches source - spec file in Am. English, legible - source matches upstream - compiles on devel (x86) - no missing, unnecessary BR - locales handled properly - post/postun ldconfig ok - not relocatable - owns all directories that it creates - no duplicate files in %files - permissions on files ok - clean ok - macros consistent - code, not content - no need for -docs - nothing in %doc affects runtime - headers and .a in -devel - pkgconfig file in -devel - suffixed libs in main package - devel requires base using n-v-r - no la libtool archives - no need for .desktop Needsfix: - Buildroot should be : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Nitpick: - You don't need to do this: %dir %{_libdir}/libtranslate/ %dir %{_libdir}/libtranslate/modules/ %{_libdir}/libtranslate/modules/*.so Instead, just do: %{_libdir}/libtranslate/ That will give you directory ownership of %{_libdir}/libtranslate/, all the directories beneath it, and all the files in it. Please correct the Needsfix and the Nitpick items before committing, but this package is APPROVED. > - rpmlint output:
> E: libtranslate outside-libdir-files /usr/share/libtranslate/services.dtd
> Safe to ignore.
Strange, my rpmlint-0.71-1 (FE3) say nothing about it...
Buildroot and libdir: done.
Whoops. Older version of rpmlint. :) Tom, Whether could you also review GUI part? (gnome-translate, bug #165960 ) I hope, that you will estimate power and all the benefits of this program for desktop users... Normalize summary field for easy parsing > Normalize summary field for easy parsing
What for?
This was closed one year ago...
(In reply to comment #11) > > Normalize summary field for easy parsing > What for? > > This was closed one year ago... As mentioned: parsing... I do that when I prepare the PackageStatus page Probably also needed when we'll populate the upcoming package database... Package Change Request ====================== Package Name: libtranslate New Branches: el6 Owners: buc Git done (by process-git-requests). |