Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 165960 - Review Request: gnome-translate - A natural language translator
Summary: Review Request: gnome-translate - A natural language translator
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
Depends On: 165353
TreeView+ depends on / blocked
Reported: 2005-08-15 10:43 UTC by Dmitry Butskoy
Modified: 2012-02-13 14:48 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-09-12 17:02:55 UTC
Type: ---
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Dmitry Butskoy 2005-08-15 10:43:48 UTC
Spec Name or Url:
SRPM Name or Url:
  GNOME Translate is a GNOME interface to libtranslate library (see bug #165353).
It can translate a text or web page between several natural languages,
and it can automatically detect the source language as you type.

  This package depends on pending "libtranslate", which I requested for review several days ago (bug #165353). IMHO, it will be more useful to examine both these packages together.

Comment 1 Aurelien Bompard 2005-09-10 14:16:10 UTC
Needs work:
* BuildRoot: should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Build: missing SMP flags ( make %{?_smp_mflags} )
* Duplicate buildRequires: glib2-devel, gtk2-devel, GConf2-devel,
libgnomeui-devel, gnome-vfs2-devel, libglade2-devel, libxml2-devel, pango-devel
* Desktop file: vendor should be fedora
* Desktop file: the Categories tag should contain X-Fedora, not X-Red-Hat-Base
* %install : /var should be replaced by %{_localstatedir}
* Check the required post and postun scriptlets on ("GConf" section and "GTK+ icon
cache" section)
* %makeinstall should be make install DESTDIR=$RPM_BUILD_ROOT
* Remove the explicit dependency on libtranslate, rpm will pick it up by itself.

Comment 2 Dmitry Butskoy 2005-09-10 18:01:21 UTC
All remarks are done, except I yet have not understood about "Duplicate
BuildRequires". Give me please little bit more information on it...


Comment 3 Aurelien Bompard 2005-09-11 12:22:52 UTC
Sure. For example, libgnomeui-devel already depends on GConf2-devel,
glib2-devel, and gnome-vfs2-devel, so you don't have to list those explicitely.
All the BR I have listed are already required by other BRs, so you can remove them.

Comment 4 Dmitry Butskoy 2005-09-12 10:28:27 UTC
I yet leave gtk2-devel and GConf2-devel, because they requires '>= 2.4.0', but
implicit dependencies give '>= 2.3.0' only.

New SRPM and SPEC at the same location (comment #2) (No release increment due to
nobody still download it... :-))

Comment 5 Michael Schwendt 2005-09-12 11:45:07 UTC
Sooner or later you will run into the trap of not updating the versioned
Buildrequires, and then you will be out-of-sync. Notice that even FC2 comes
with a version of gtk2-devel, which is new enough, so all the distributions
your Fedora Extras package targets, are sufficient.

Versioned [build] dependencies make much more sense, when the package from
original version of a distribution is insufficient, but an Update is
available and required.

Comment 6 Dmitry Butskoy 2005-09-12 12:02:21 UTC
For comment #5 :
  It is possible that someone will rebuild this package under some "old enough"
distribution (fc1, rhl7.3 etc.), or even under some another Fedora-based
distribution. Therefore I think this versioning is a little bit useful.
  I hope that it is not required to update these dependences in the future (at
least, visible future), because it is ">=", not "==" ...

Comment 7 Aurelien Bompard 2005-09-12 13:23:55 UTC
> No release increment due to nobody still download it...

Please do increment. It helps when saying "Release x approved", and it also
helps the reviewer.

> I hope that it is not required to update these dependences in the future

If the upstream project depends on newer libs, you'll have to reflect this in
your  RPM. But if you're willing to follow that, that's fine. You're the
maintainer in the end.

Last problem in the spec file: since it installs a scrollkeeper file, you have
to add the required bits in the scriptlets. Please see, scrollkeeper section.

Comment 9 Aurelien Bompard 2005-09-12 14:44:26 UTC
=== Review for release 3 ===
* RPM name is OK
* Source gnome-translate-0.99.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of gnome-translate looks OK
* File list of gnome-translate looks OK
* Seems to work fine

Comment 10 Dmitry Butskoy 2012-02-13 12:08:21 UTC
Package Change Request
Package Name: gnome-translate
New Branches: el6
Owners: buc

Comment 11 Gwyn Ciesla 2012-02-13 14:48:13 UTC
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.