Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165836
Summary: | Review Request: cogito | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Wright <chrisw> |
Component: | Package Review | Assignee: | Greg DeKoenigsberg <gdk> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, jwboyer |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.kernel.org/pub/linux/kernel/people/chrisw/git/review/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-09-17 00:54:51 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 165833 | ||
Bug Blocks: | 163779 |
Description
Chris Wright
2005-08-12 18:31:06 UTC
Getting a 403 error on the spec file. Forbidden You don't have permission to access /pub/linux/kernel/people/chrisw/git/review/cogito.spec on this server. I'll try and take a look this weekend. Do you have a sponsor for Fedora Extras yet? Ugh, sorry about that. Both should be readable now. No I don't have a sponsor. Nits:
1) Buildroot should be:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
to match up with the Packaging guidelines for FE.
2) Normally FE packages don't carry the Vendor: tag
3) Prereq: could probably be turned into Requires: and everything but git-core
>= 0.99.3 could probably be dropped. git-core already requires the rest of the
items in that list
4) /usr/lib can be replaced by %{_libdir}
More review after I get git-core building and installed.
As for a sponsor, I've briefly spoken with Ed Hill. Hopefully he will be able
to help out there.
- Buildroot updated to: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Vendor tag dropped - Prereq turned to Requires, and now only depends on git-core >= 0.99.3 - Replace /usr/lib with %{_libdir} New .src.rpm and .spec are uploading to: http://kernel.org/pub/linux/kernel/people/chrisw/git/review/cogito-0.13-3.src.rpm http://kernel.org/pub/linux/kernel/people/chrisw/git/review/cogito.spec Thanks for review and help with sponsor. Updates look good. I think this one is mostly done. Still working on the sponsor. Great, I'll feed the changes back upstream in the meantime. Any progress being made here? Uploaded package to CVS. Just noticed missing %{dist}. Is there any reason not to add for this noarch package? Hi Chris, %{dist} isn't required but it certainly does make things easier when you have multiple branches (FC-4, devel, etc.) and you do a "make tag". OK, I'll go ahead and add this. Thanks Ed. Also fixup _libdir usage which happens to break this noarch package on arches with _libdir == /usr/lib64, the irony ;-) |