Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 165836 - Review Request: cogito
Summary: Review Request: cogito
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Greg DeKoenigsberg
QA Contact: David Lawrence
Depends On: 165833
TreeView+ depends on / blocked
Reported: 2005-08-12 18:31 UTC by Chris Wright
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-09-17 00:54:51 UTC
Type: ---

Attachments (Terms of Use)

Description Chris Wright 2005-08-12 18:31:06 UTC
Spec Name or Url:
SRPM Name or Url:
Description: cogito provides a nice user interface to git-core.  this package is dependent on git-core.

Comment 1 Josh Boyer 2005-08-13 02:15:58 UTC
Getting a 403 error on the spec file.


You don't have permission to access
/pub/linux/kernel/people/chrisw/git/review/cogito.spec on this server.

I'll try and take a look this weekend.  Do you have a sponsor for Fedora Extras yet?

Comment 2 Chris Wright 2005-08-13 07:08:38 UTC
Ugh, sorry about that.  Both should be readable now.  No I don't have a sponsor.

Comment 3 Josh Boyer 2005-08-13 19:06:52 UTC

1) Buildroot should be:

%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

to match up with the Packaging guidelines for FE.

2) Normally FE packages don't carry the Vendor: tag

3) Prereq: could probably be turned into Requires: and everything but git-core
>= 0.99.3 could probably be dropped.  git-core already requires the rest of the
items in that list

4) /usr/lib can be replaced by %{_libdir}

More review after I get git-core building and installed.

As for a sponsor, I've briefly spoken with Ed Hill.  Hopefully he will be able
to help out there.

Comment 4 Chris Wright 2005-08-15 17:28:25 UTC
- Buildroot updated to:

%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

- Vendor tag dropped

- Prereq turned to Requires, and now only depends on git-core >= 0.99.3

- Replace /usr/lib with %{_libdir}

New .src.rpm and .spec are uploading to:

Thanks for review and help with sponsor.

Comment 5 Josh Boyer 2005-08-18 00:06:25 UTC
Updates look good.  I think this one is mostly done.  Still working on the sponsor.

Comment 6 Chris Wright 2005-08-18 00:10:59 UTC
Great, I'll feed the changes back upstream in the meantime.

Comment 7 Josh Boyer 2005-09-13 17:11:27 UTC
Any progress being made here?

Comment 8 Chris Wright 2005-09-16 07:15:24 UTC
Uploaded package to CVS.

Comment 9 Chris Wright 2005-09-16 22:15:54 UTC
Just noticed missing %{dist}.  Is there any reason not to add for this noarch

Comment 10 Ed Hill 2005-09-16 23:07:36 UTC
Hi Chris, %{dist} isn't required but it certainly does make things easier when
you have multiple branches (FC-4, devel, etc.) and you do a "make tag".

Comment 11 Chris Wright 2005-09-17 00:03:44 UTC
OK, I'll go ahead and add this.  Thanks Ed.  Also fixup _libdir usage which
happens to break this noarch package on arches with _libdir == /usr/lib64, the
irony ;-)

Note You need to log in before you can comment on or make changes to this bug.