Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 166567

Summary: Review Request: perl-Date-Simple (Simple date object for perl)
Product: [Fedora] Fedora Reporter: Paul Howarth <paul>
Component: Package ReviewAssignee: Tom "spot" Callaway <tcallawa>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-extras-list, tcallawa
Target Milestone: ---Flags: petersen: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://www.city-fan.org/~paul/extras/perl-Date-Simple/
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-08-24 07:19:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779, 166182, 166184    

Description Paul Howarth 2005-08-23 13:20:55 UTC
Spec Name or Url: http://www.city-fan.org/~paul/extras/perl-Date-Simple/perl-Date-Simple.spec
SRPM Name or Url: http://www.city-fan.org/~paul/extras/perl-Date-Simple/perl-Date-Simple-3.02-1.src.rpm
Description: 

Simple date object for perl.

This is a dependency of perl-CGI-Untaint-date, which in turn is a dependency of perl-Maypole.

Comment 1 Ralf Corsepius 2005-08-23 16:08:58 UTC
NEEDSWORK:

> Url:            http://cpan.uwinnipeg.ca/module/Date::Simple
> Source0:       
http://cpan.uwinnipeg.ca/cpan/authors/id/Y/YV/YVES/Date-Simple-%{version}.tar.gz

Please use CPAN rooted URLs, uwinnipeg.ca probably is csearch.cpan.org mirror.

Comment 2 Paul Howarth 2005-08-23 16:18:41 UTC
OK, I prefer that interface myself but it's no big deal.

How about:

Url: http://search.cpan.org/dist/Date-Simple/
Source0:
http://search.cpan.org/CPAN/authors/id/Y/YV/YVES/Date-Simple-%{version}.tar.gz


Comment 3 Tom "spot" Callaway 2005-08-23 16:27:01 UTC
*** Bug 166579 has been marked as a duplicate of this bug. ***

Comment 4 Tom "spot" Callaway 2005-08-23 16:29:25 UTC
With the fixed URL, this package looks good to me.

- rpmlint checks return nothing
- meets naming/packaging guidelines
- macro use is consistent
- license ok (perl), both texts include, matches source
- source matches upstream
- no libs, no docs
- spec is legible, in am english
- code, not content
- builds ok (FC4, ppc)
- owns directories it makes
- no missing, unnecessary BR

With the URL changes, this one is approved.


Comment 5 Paul Howarth 2007-08-30 10:55:08 UTC
Package Change Request
======================
Package Name: perl-Date-Simple
New Branches: EL-4 EL-5

Comment 6 Jens Petersen 2007-08-31 01:39:55 UTC
added