Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166567 - Review Request: perl-Date-Simple (Simple date object for perl)
Summary: Review Request: perl-Date-Simple (Simple date object for perl)
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: David Lawrence
URL: http://www.city-fan.org/~paul/extras/...
Whiteboard:
: 166579 (view as bug list)
Depends On:
Blocks: FE-ACCEPT 166182 166184
TreeView+ depends on / blocked
 
Reported: 2005-08-23 13:20 UTC by Paul Howarth
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-08-24 07:19:37 UTC
Type: ---
Embargoed:
petersen: fedora-cvs+

Attachments (Terms of Use)

Description Paul Howarth 2005-08-23 13:20:55 UTC 
Spec Name or Url: http://www.city-fan.org/~paul/extras/perl-Date-Simple/perl-Date-Simple.spec
SRPM Name or Url: http://www.city-fan.org/~paul/extras/perl-Date-Simple/perl-Date-Simple-3.02-1.src.rpm
Description: 

Simple date object for perl.

This is a dependency of perl-CGI-Untaint-date, which in turn is a dependency of perl-Maypole.
Comment 1 Ralf Corsepius 2005-08-23 16:08:58 UTC 
NEEDSWORK:

> Url:            http://cpan.uwinnipeg.ca/module/Date::Simple
> Source0:       
http://cpan.uwinnipeg.ca/cpan/authors/id/Y/YV/YVES/Date-Simple-%{version}.tar.gz

Please use CPAN rooted URLs, uwinnipeg.ca probably is csearch.cpan.org mirror.
Comment 2 Paul Howarth 2005-08-23 16:18:41 UTC 
OK, I prefer that interface myself but it's no big deal.

How about:

Url: http://search.cpan.org/dist/Date-Simple/
Source0:
http://search.cpan.org/CPAN/authors/id/Y/YV/YVES/Date-Simple-%{version}.tar.gz
Comment 3 Tom "spot" Callaway 2005-08-23 16:27:01 UTC 
*** Bug 166579 has been marked as a duplicate of this bug. ***
Comment 4 Tom "spot" Callaway 2005-08-23 16:29:25 UTC 
With the fixed URL, this package looks good to me.

- rpmlint checks return nothing
- meets naming/packaging guidelines
- macro use is consistent
- license ok (perl), both texts include, matches source
- source matches upstream
- no libs, no docs
- spec is legible, in am english
- code, not content
- builds ok (FC4, ppc)
- owns directories it makes
- no missing, unnecessary BR

With the URL changes, this one is approved.
Comment 5 Paul Howarth 2007-08-30 10:55:08 UTC 
Package Change Request
======================
Package Name: perl-Date-Simple
New Branches: EL-4 EL-5
Comment 6 Jens Petersen 2007-08-31 01:39:55 UTC 
added
Note You need to log in before you can comment on or make changes to this bug.