Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 166928

Summary:	Review Request: numlockx
Product:	[Fedora] Fedora	Reporter:	John Mahowald <jpmahowald>
Component:	Package Review	Assignee:	Tom "spot" Callaway <tcallawa>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://ktown.kde.org/~seli/numlockx
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-09-12 17:16:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description John Mahowald 2005-08-28 03:31:30 UTC

Spec Name or Url: http://personal.stthomas.edu/jpmahowald1/fedora/review/numlockx.spec
SRPM Name or Url: http://personal.stthomas.edu/jpmahowald1/fedora/review/numlockx-1.0-2.src.rpm
Description: NumLockX turns on NumLock after starting X

My first package, I need a sponsor and CVS. Fedora username jpmahowa

Comment 1 Tom "spot" Callaway 2005-08-28 17:46:00 UTC

Review:

Good:
- rpmlint check returns: W: numlockx strange-permission numlockx.sh 0775
  safe to ignore
- meets naming and packaging guidelines
- license ok (MIT), matches source, text included as %doc
- spec is legible, in am. english
- source matches upstream
- package compiles on x86 (FC4)
- no unnecessary, missing BuildRequires (./configure looks for xinitrc, but
never uses it for anything)
- no need for -devel, -docs
- no locales
- not relocatable
- creates no new directories
- no duplicate %files
- permissions ok
- %clean ok
- macro use is consistent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop

Nitpicks:
- %{_bindir} is cleaner than %{_usr}/bin/ ... please make that change.
- you might consider using %{version} in the Source0 line instead of hardcoding
the tarball version

Please change to %{_bindir} before committing, but this package is APPROVED.

I'll also go sponsor you right now.

Comment 2 John Mahowald 2005-08-29 13:08:46 UTC

Nitpicks fixed, thanks.

New version available from
http://frontiernet.net/~jpmahowald/fedora/review/numlockx.spec and
http://frontiernet.net/~jpmahowald/fedora/review/numlockx-1.0-3.src.rpm

Importing into CVS.