Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166928 - Review Request: numlockx
Summary: Review Request: numlockx
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: David Lawrence
URL: http://ktown.kde.org/~seli/numlockx
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-08-28 03:31 UTC by John Mahowald
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-09-12 17:16:27 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description John Mahowald 2005-08-28 03:31:30 UTC 
Spec Name or Url: http://personal.stthomas.edu/jpmahowald1/fedora/review/numlockx.spec
SRPM Name or Url: http://personal.stthomas.edu/jpmahowald1/fedora/review/numlockx-1.0-2.src.rpm
Description: NumLockX turns on NumLock after starting X

My first package, I need a sponsor and CVS. Fedora username jpmahowa
Comment 1 Tom "spot" Callaway 2005-08-28 17:46:00 UTC 
Review:

Good:
- rpmlint check returns: W: numlockx strange-permission numlockx.sh 0775
  safe to ignore
- meets naming and packaging guidelines
- license ok (MIT), matches source, text included as %doc
- spec is legible, in am. english
- source matches upstream
- package compiles on x86 (FC4)
- no unnecessary, missing BuildRequires (./configure looks for xinitrc, but
never uses it for anything)
- no need for -devel, -docs
- no locales
- not relocatable
- creates no new directories
- no duplicate %files
- permissions ok
- %clean ok
- macro use is consistent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop

Nitpicks:
- %{_bindir} is cleaner than %{_usr}/bin/ ... please make that change.
- you might consider using %{version} in the Source0 line instead of hardcoding
the tarball version

Please change to %{_bindir} before committing, but this package is APPROVED.

I'll also go sponsor you right now.
Comment 2 John Mahowald 2005-08-29 13:08:46 UTC 
Nitpicks fixed, thanks.

New version available from
http://frontiernet.net/~jpmahowald/fedora/review/numlockx.spec and
http://frontiernet.net/~jpmahowald/fedora/review/numlockx-1.0-3.src.rpm

Importing into CVS.
Note You need to log in before you can comment on or make changes to this bug.