Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 167512
Summary: | Review Request: perl-Algorithm-Diff | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Steven Pritchard <steve> |
Component: | Package Review | Assignee: | Paul Howarth <paul> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | bochecha, fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/Algorithm-Diff/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-09-06 18:13:23 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Steven Pritchard
2005-09-03 20:51:20 UTC
Is there some particular reason why you're packaging version 1.15 rather than version 1.1901? Yes. 1.1901 is distributed as a zip file, and I haven't taken the time to figure out how to deal with that (yet). 1.15 (the previous version) is distributed as a standard .tar.gz. Rpmbuild handles zip files without problems. Take a look at this specfile: http://gsd.di.uminho.pt/jpo/software/fedora/perl-Algorithm-Diff.spec Sorry, I should have been more specific. It isn't that rpmbuild can't handle it, it's that cpanspec can't. I could pretty easily update the spec file manually to work with the newer version, but the old version seems to work fine. I'm planning on updating cpanspec to handle the newer version RSN. OK, nevermind, I fixed that problem. :-) Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-Algorithm-Diff/perl-Algorithm-Diff.spec SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-Algorithm-Diff-1.1901-1.src.rpm Review: - rpmlint clean - package and spec file naming OK - package meets guidelines - license is same as perl, matches spec, text included - spec written in English and is legible - sources match upstream - package builds OK in mock for FC4 and development (i386) - no explicit BRs - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions issues - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Approved. This package is in EPEL5, but not in EPEL6. Is there any reason for that? I would like to see this package in EPEL6, and I am willing to help co-maintain it. Nevermind, I just saw it's in the RHEL6 Client repository (I was only looking at the Server one). Sorry for the spam. |