Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 167512 - Review Request: perl-Algorithm-Diff
Summary: Review Request: perl-Algorithm-Diff
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
URL: http://search.cpan.org/dist/Algorithm...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-09-03 20:51 UTC by Steven Pritchard
Modified: 2011-01-19 09:39 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-09-06 18:13:23 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Steven Pritchard 2005-09-03 20:51:20 UTC 
Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Algorithm-Diff/perl-Algorithm-Diff.spec
SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Algorithm-Diff-1.15-2.src.rpm
Description:
This is a module for computing the difference between two files, two
strings, or any other two lists of things.  It uses an  intelligent
algorithm similar to (or identical to) the one used by the Unix `diff'
program.   It is guaranteed to find the *smallest possible* set of
differences.
Comment 1 Paul Howarth 2005-09-05 10:07:35 UTC 
Is there some particular reason why you're packaging version 1.15 rather than
version 1.1901?
Comment 2 Steven Pritchard 2005-09-05 17:20:03 UTC 
Yes.  1.1901 is distributed as a zip file, and I haven't taken the time to
figure out how to deal with that (yet).  1.15 (the previous version) is
distributed as a standard .tar.gz.
Comment 3 Jose Pedro Oliveira 2005-09-05 17:24:25 UTC 
Rpmbuild handles zip files without problems.

Take a look at this specfile:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Algorithm-Diff.spec
Comment 4 Steven Pritchard 2005-09-05 17:43:07 UTC 
Sorry, I should have been more specific.  It isn't that rpmbuild can't handle
it, it's that cpanspec can't.

I could pretty easily update the spec file manually to work with the newer
version, but the old version seems to work fine.  I'm planning on updating
cpanspec to handle the newer version RSN.
Comment 5 Steven Pritchard 2005-09-05 18:30:03 UTC 
OK, nevermind, I fixed that problem.  :-)

Spec URL:
http://ftp.kspei.com/pub/steve/rpms/perl-Algorithm-Diff/perl-Algorithm-Diff.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-Algorithm-Diff-1.1901-1.src.rpm
Comment 6 Paul Howarth 2005-09-06 10:26:57 UTC 
Review:

- rpmlint clean
- package and spec file naming OK
- package meets guidelines
- license is same as perl, matches spec, text included
- spec written in English and is legible
- sources match upstream
- package builds OK in mock for FC4 and development (i386)
- no explicit BRs
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Approved.
Comment 7 Mathieu Bridon 2011-01-19 09:05:09 UTC 
This package is in EPEL5, but not in EPEL6. Is there any reason for that?

I would like to see this package in EPEL6, and I am willing to help co-maintain it.
Comment 8 Mathieu Bridon 2011-01-19 09:39:46 UTC 
Nevermind, I just saw it's in the RHEL6 Client repository (I was only looking at the Server one).

Sorry for the spam.
Note You need to log in before you can comment on or make changes to this bug.