Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 167885
Summary: | Review Request: libpolyxmass - Polymer chemistry-related functionalities | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andreas Bierfert <andreas.bierfert> |
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, jpmahowald |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.polyxmass.org | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-10-21 23:29:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 167887 |
Description
Andreas Bierfert
2005-09-09 07:36:06 UTC
Missing BuildRequires: glib2-devel Minor: rpmlint wants changelog version on the same line: W: libpolyxmass no-version-in-last-changelog W: libpolyxmass-debuginfo no-version-in-last-changelog W: libpolyxmass-devel no-version-in-last-changelog fixed missing BR. changelog in this case is ok because my name is (to) long... http://fedora.lowlatency.de/review/libpolyxmass-0.8.9-2.src.rpm http://fedora.lowlatency.de/review/libpolyxmass.spec The URL line is longer, but oh well. - license good (GPL), text in %doc - name follows guidelines - spec file easily read - builds on FC4 i386 - rpmlint only warns about changelog, can ignore - used %find_lang macro - sources match upstream - no missing/unneeded BuildRequires - consistent macro usage - %post and %postun ldconfig - devel package only installs a symlink, no need for ldconfig - %clean good - *.la removed However, - no %defattr for devel package fixed defattr... http://fedora.lowlatency.de/review/libpolyxmass-0.8.9-3.src.rpm http://fedora.lowlatency.de/review/libpolyxmass.spec Looks good with the defattr added. APPROVED Thanks for the review... :) |