Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 167885 - Review Request: libpolyxmass - Polymer chemistry-related functionalities
Summary: Review Request: libpolyxmass - Polymer chemistry-related functionalities
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: John Mahowald
QA Contact: David Lawrence
Depends On:
Blocks: FE-ACCEPT 167887
TreeView+ depends on / blocked
Reported: 2005-09-09 07:36 UTC by Andreas Bierfert
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-10-21 23:29:56 UTC
Type: ---

Attachments (Terms of Use)

Description Andreas Bierfert 2005-09-09 07:36:06 UTC
Spec Name or Url:
SRPM Name or Url:
libpolyxmass is a library that implements some housekeeping
functionalities and polymer chemistry-related functionalities that are
used in the other modules of the GNU polyxmass mass spectrometry
framework. It was born as the merge of the two libpxmutils and
libpxmchem libraries (last versions of these two libraries were for
both 0.7.0). This fact is still visible as the files do have either
"pxmutils-" or "pxmchem-" as prefix in their name. This nomenclature
is going to be maintained as it helps understanding the
functionalities that are housed in the different files of the new

Comment 1 John Mahowald 2005-10-20 16:25:24 UTC
Missing BuildRequires: glib2-devel

Minor: rpmlint wants changelog version on the same line: 

W: libpolyxmass no-version-in-last-changelog
W: libpolyxmass-debuginfo no-version-in-last-changelog
W: libpolyxmass-devel no-version-in-last-changelog

Comment 2 Andreas Bierfert 2005-10-20 20:07:03 UTC
fixed missing BR.

changelog in this case is ok because my name is (to) long...

Comment 3 John Mahowald 2005-10-20 22:15:43 UTC
The URL line is longer, but oh well.

- license good (GPL), text in %doc
- name follows guidelines
- spec file easily read
- builds on FC4 i386
- rpmlint only warns about changelog, can ignore
- used %find_lang macro
- sources match upstream
- no missing/unneeded BuildRequires
- consistent macro usage
- %post and %postun ldconfig
- devel package only installs a symlink, no need for ldconfig
- %clean good
- *.la removed

- no %defattr for devel package

Comment 5 John Mahowald 2005-10-21 00:54:48 UTC
Looks good with the defattr added.


Comment 6 Andreas Bierfert 2005-10-21 23:29:56 UTC
Thanks for the review... :)

Note You need to log in before you can comment on or make changes to this bug.