Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 167887
Summary: | Review Request: polyxmass-bin - The GNU polyxmass software suite | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andreas Bierfert <andreas.bierfert> |
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.polyxmass.org | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-10-27 05:01:40 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 167885 | ||
Bug Blocks: | 163779, 167888, 167889 |
Description
Andreas Bierfert
2005-09-09 07:40:07 UTC
* name OK, matches upstream (though I would probably have just called it polyxmass) * license good (GPL), in %doc * specfile legible * builds on FC4 i386 * uses %find_lang * owns its directories * consistent macro use * %clean OK * %docs good, no need for seperate package * app runs needs work: * .desktop file, installed with desktop-file-install * minor: rpmlint only can't find changelog version: W: polyxmass-bin no-version-in-last-changelog W: polyxmass-bin-debuginfo no-version-in-last-changelog the purpose of the patch is to make it compile without -Werror? yes thats what the patch is for because optflags make the build noisy... desktop icon has been added =) http://fedora.lowlatency.de/review/polyxmass-bin.spec http://fedora.lowlatency.de/review/polyxmass-bin-0.8.9-2.src.rpm The desktop file was added, but it really needs an icon. I suggest /usr/share/polyxmass/glade/polyxmass-icon-32x32.png This line to the desktop file should do it: Icon=/usr/share/polyxmass/glade/polyxmass-icon-32x32.png Here you go :) http://fedora.lowlatency.de/review/polyxmass-bin-0.8.9-3.src.rpm http://fedora.lowlatency.de/review/polyxmass-bin.spec Looks good with the icon. APPROVED checked in and build... could you please change to FE-ACCEPT? Thanks. |