Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 168187

Summary:	Review request: perl-File-Flat - Implements a flat filesystem
Product:	[Fedora] Fedora	Reporter:	Ralf Corsepius <rc040203>
Component:	Package Review	Assignee:	Paul Howarth <paul>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list, lkundrak
Target Milestone:	---	Flags:	gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/File-Flat/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-09-23 06:22:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	167282, 167381, 168160, 168174, 168186, 168194
Bug Blocks:	163779, 168213

Description Ralf Corsepius 2005-09-13 11:10:37 UTC

Spec Name or Url:
ftp://packman.iu-bremen.de/fedora/SRPMS/perl-File-Flat.spec

SRPM Name or Url:
ftp://packman.iu-bremen.de/fedora/SRPMS/perl-File-Flat-0.95-1.src.rpm

Description:
File::Flat implements a flat filesystem. A flat filesystem is a filesystem
in which directories do not exist. It provides an abstraction over any
normal filesystem which makes it appear as if directories do not exist.

Comment 1 Paul Howarth 2005-09-19 12:05:25 UTC

Review:

- rpmlint clean
- package and spec naming OK
- license is same as perl, matches spec, text included
- spec file written in English and is legible
- source matches upstream
- builds OK in mock for FC4 (i386)
- BR's look OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no duplicate files
- no directory ownership or permissions issues
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop file needed
- no scriptlets

Query:

- where did the specific version dependencies for File::Copy, File::Find and
  IO::File come from? Makefile.PL just seems to check for *any* version of
  these modules rather than specific versions

Approved.

Comment 2 Ralf Corsepius 2005-09-19 13:22:51 UTC

(In reply to comment #1)

> - where did the specific version dependencies for File::Copy, File::Find and
>   IO::File come from? 
Probably a braino + cut'n'pasto on my part - Usually cut'n'paste these checks
logs into the spec and edit them.

Seems as if I added the "currently installed versions the checks reported"
instead of the required versions. To be fixed post-commit.

Comment 3 Lubomir Rintel 2014-01-21 17:52:35 UTC

Package Change Request
======================
Package Name: perl-File-Flat
New Branches: epel7
Owners: lkundrak

The Fedora maintainer (Ralf Corsepius, corsepiu) is not willing to maintain EPEL packages.

Comment 4 Gwyn Ciesla 2014-01-21 18:05:19 UTC

Git done (by process-git-requests).