Review:

- rpmlint clean
- package and spec file name OK
- package meets guidelines
- license is same as perl, matches upstream
- spec file written in English and is legible
- sources match upstream
- builds OK in mock on FC4 (i386)
- BRs OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions problems
- no duplicate files
- %clean section present and correct
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Needswork:

- URL for Source0 is 404-compliant
- license text not included

Suggestions:

- Summary could be clearer I think; how about:
  Copy files to directories, or a single file to another file

Created attachment 118390 [details]
Patch addressing review issues

(In reply to comment #1)

> - URL for Source0 is 404-compliant
What kind of superfluous kind of convention are you trying to invent now?

> - Summary could be clearer I think; how about:
>   Copy files to directories, or a single file to another file
This is the original dist description from
http://search.cpan.org/dist/File-NCopy

(In reply to comment #3)
> (In reply to comment #1)
> 
> > - URL for Source0 is 404-compliant
> What kind of superfluous kind of convention are you trying to invent now?

This one:

$ spectool --gf perl-File-NCopy.spec
--13:44:12--  http://www.cpan.org/modules/by-module/File/File-NCopy-0.34.tar.gz
           => `./File-NCopy-0.34.tar.gz'
Resolving www.cpan.org... 66.39.76.93
Connecting to www.cpan.org[66.39.76.93]:80... connected.
HTTP request sent, awaiting response... 404 Not Found
13:44:12 ERROR 404: Not Found.

> > - Summary could be clearer I think; how about:
> >   Copy files to directories, or a single file to another file
> This is the original dist description from
> http://search.cpan.org/dist/File-NCopy

I know it is. That doesn't make it a clear description of what the package is
for. I believe my suggestion is much clearer, but it's only a suggestion; feel
free to use the original text if you prefer.

This link works
http://www.cpan.org/authors/id/M/MZ/MZSANFORD/File-NCopy-0.34.tar.gz

It appears to be a missing or a broken symbolic link. The tarballs in CPAN
are all located under the authors directory tree.  All others references
(e.g. from the modules directory) are symbolic links.

Updates to appear soon at:
ftp://packman.iu-bremen.de/fedora/SRPMS/perl-File-NCopy.spec
ftp://packman.iu-bremen.de/fedora/SRPMS/perl-File-NCopy-0.34-2.src.rpm

License text still missing, no changelog entry.

To get the package approved just add following line

   "# For license text(s), see the perl package."

to the %files section (and the changelog entry).


Example
-------

--- perl-File-NCopy.spec.2      2005-09-02 14:50:15.000000000 +0100
+++ perl-File-NCopy.spec        2005-09-10 02:38:20.000000000 +0100
@@ -37,6 +37,7 @@

 %files
 %defattr(-,root,root,-)
+# For license text(s), see the perl package.
 %doc Changes
 %{perl_vendorlib}/File
 %{_mandir}/man3/*

Since the license text policy has now changed, this package meets the guidelines
and is Approved.

Please fix the changelog entry though to make the release consistent, and
s/www/search/ on the Source0 URL.

Aargh. Forget the bit about Source0; the current URL works fine.