Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1689076
Summary: | Review Request: golang-github-gosimple-slug - URL-friendly slugify with multiple languages support | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nathan Scott <nathans> |
Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | lberk, mgoodwin, package-review, quantum.analyst, zebob.m |
Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-03-15 22:40:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1670656 |
Description
Nathan Scott
2019-03-15 05:45:52 UTC
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33503834 (currently failing as golang-github-rainycape-unidecode is not yet available in the rawhide buildroot) - You need to add the BR even if it's not pacaged yet BuildRequires: golang(github.com/rainycape/unidecode) And you need to provide a Review Request for that package otherwise it can't be reviewed. | BuildRequires: golang(github.com/rainycape/unidecode) Aha, that's all I was missing - thanks. | And you need to provide a Review Request for that package You reviewed it earlier this week. ;-) Updated SPEC and SRPM (same location as above), Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=33504705 I did? The package name was ringing a bell. Anyhow: - Fix the line encoding of the README.md in %prep golang-github-gosimple-slug-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-gosimple-slug-devel/README.md See https://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. Please fix the line issue before import. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gosimple-slug Thanks again Robert-André; I've added the line endings fix and have pushed through first builds now. golang-github-gosimple-slug-1.4.2-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8e60a710a7 golang-github-gosimple-slug-1.4.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8e60a710a7 golang-github-gosimple-slug-1.4.2-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d3e1194a61 golang-github-gosimple-slug-1.4.2-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d3e1194a61 golang-github-gosimple-slug-1.4.2-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. |