Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 169927
| Summary: | Review Request: scim-fcitx - Chinese IMEngine for SCIM | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list, qshen |
| Target Milestone: | --- | Keywords: | i18n |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.scim-im.org/projects/imengines | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-01-10 01:33:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Jens Petersen
2005-10-05 11:01:55 UTC
* RPM name is OK * Source scim-fcitx.3.1.1.tar.bz2 is the same as upstream * Builds fine in mock * rpmlint of scim-fcitx-tools looks OK * File list of scim-fcitx-tools looks OK Needs work: * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * rpmlint of scim-fcitx: Don't need empty file NEWS. * File list of scim-fcitx: %{_datadir}/scim and %{_libdir}/scim are already owned by scim package * %defattr(-, root, root) really should be %defattr(-, root, root,-) Thank you for the careful review. I uploaded a new package which should fix all the points you found: http://people.redhat.com/petersen/extras/scim-fcitx-3.1.1-1.1.src.rpm http://people.redhat.com/petersen/extras/scim-fcitx.spec The careful review is mostly thanks to the fedora-qa script. rpmlint - rpmlint of scim-fcitx: Missing changelog entry, minor - rpmlint of scim-fcitx-tools: No docs, ignore. - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc - spec file legible, in am. english - source matches upstream - package compiles on FC4 i386 - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Note that I have not tested using this. APPROVED I've tested it -- works very nicely. Better interface than the default pinyin input method provided by scim, at least in my opinion. Looking forward to seeing it in Extras. Package imported into cvs, devel build and cvs branches requested. (In reply to comment #5) > Package imported into cvs, devel build and cvs branches requested. Could you please set the ticket to CLOSED / NEXTRELEASE ? Thanks. Done, thanks. |