Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 169973
Summary: | Review Request: python-clientform - ClientForm | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Josh Boyer <jwboyer> |
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://wwwsearch.sourceforge.net/ClientForm/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-11-04 03:51:10 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Josh Boyer
2005-10-06 00:04:35 UTC
I'd personally name it "python-clientform" (all lowercase). Please at least add the "python-" prefix. The module name is ClientForm so the proper name would be python-ClientForm. The majority of python-* in Extras seem to disagree with that (based on quickly peeking into the source tarball names only). The prefix is a MUST. The lowercase is up to the packager. Ok, updated spec file and srpm at: http://jdub.homelinux.org/files/ClientForm/python-clientform.spec and http://jdub.homelinux.org/files/ClientForm/python-clientform-0.1.17-2.src.rpm Needs work: - *.pyo needs to be %ghost ed Summary doesn't seem to match the package: Summary: Powerful extensions to the standard datetime module Is this the right Summary? Minor: - typo in Source1, net not not: http://wwwsearch.sourceforge.not/ClientForm/src/ClientForm-0.1.17.tar.gz Good: - BSD license, text included - spec legible - source matches upstream - builds on FC4 - follows python template - owns all it's files - rpmlint clean (In reply to comment #6) > Needs work: > > - *.pyo needs to be %ghost ed Ok, I think I fixed this... (first time packaging python) > > Summary doesn't seem to match the package: > Summary: Powerful extensions to the standard datetime module > Is this the right Summary? No. Blatant copy/paste error. Fixed. > > Minor: > - typo in Source1, net not not: > http://wwwsearch.sourceforge.not/ClientForm/src/ClientForm-0.1.17.tar.gz Fixed. Updated spec files and srpm at: http://jdub.homelinux.org/files/ClientForm/python-clientform.spec and http://jdub.homelinux.org/files/ClientForm/python-clientform-0.1.17-3.src.rpm Looks good. APPROVED branched, tagged, and built. thanks for the review! Normalize summary field for easy parsing |