Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1701226
| Summary: | bodhi 3.14.0-1.fc31 FTBFS on Python 3.8 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> | ||||||
| Component: | bodhi | Assignee: | Randy Barlow <rbarlow> | ||||||
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | infra-sig, jeremy, rbarlow | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2019-04-23 15:12:04 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 1544163 | ||||||||
| Bug Blocks: | 1686977 | ||||||||
| Attachments: |
|
||||||||
It looks like pytest didn't collect a significant number of tests. If you look at the warning output you'll see it listing a list of tests that it didn't collect. I'm not sure why. I'll add this to my todo list. kernel-tools-5.0.9-300.fc30 kernel-headers-5.0.9-300.fc30 kernel-5.0.9-300.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-e84f6c34da kernel-tools-5.0.9-200.fc29 kernel-headers-5.0.9-200.fc29 kernel-5.0.9-200.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1e8a4c6958 kernel-tools-5.0.9-100.fc28 kernel-headers-5.0.9-100.fc28 kernel-5.0.9-100.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1b986880ea Created attachment 1557245 [details]
py.test-3 --collect-only output
> It looks like pytest didn't collect a significant number of tests.
I'm not sure this is true, see bellow:
Python 3.8 in Copr:
FAIL Required test coverage of 97% not reached. Total coverage: 60.64%
================= 1587 passed, 2103 warnings in 269.03 seconds =================
Python 3.7 in the latest Koji build:
Required test coverage of 97% reached. Total coverage: 99.13%
================= 1587 passed, 3758 warnings in 229.42 seconds =================
Yes, there are more warnings. But the number of collected tests is 1587.
Yeah you are right. Hmm. I wonder if coverage is not working as expected? I'm not sure I have any other ideas. https://coverage.readthedocs.io/en/v4.5.x/changes.html 4.5.2 seems important Thanks for tracking that down Miro! |
Created attachment 1556126 [details] Full log from Copr bodhi 3.14.0-1.fc31 %check fails on Python 3.8: FAIL Required test coverage of 97% not reached. Total coverage: 60.64% I don't know why the coverage is lower on Python 3.8, maybe it is just a symptom of another problem. While measuring test coverage makes sense in upstream, I don't think the RPM package should FTBFS because of that. Full log attached.