Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1701226 - bodhi 3.14.0-1.fc31 FTBFS on Python 3.8
Summary: bodhi 3.14.0-1.fc31 FTBFS on Python 3.8
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: bodhi
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Randy Barlow
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1544163
Blocks: PYTHON38
TreeView+ depends on / blocked
 
Reported: 2019-04-18 12:22 UTC by Miro Hrončok
Modified: 2019-04-23 15:43 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-04-23 15:12:04 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Full log from Copr (735.70 KB, text/plain)
2019-04-18 12:22 UTC, Miro Hrončok 		no flags Details
py.test-3 --collect-only output (97.38 KB, text/plain)
2019-04-22 18:15 UTC, Miro Hrončok 		no flags Details
View All

Description Miro Hrončok 2019-04-18 12:22:28 UTC 
Created attachment 1556126 [details]
Full log from Copr

bodhi 3.14.0-1.fc31 %check fails on Python 3.8:

FAIL Required test coverage of 97% not reached. Total coverage: 60.64%

I don't know why the coverage is lower on Python 3.8, maybe it is just a symptom of another problem.

While measuring test coverage makes sense in upstream, I don't think the RPM package should FTBFS because of that.

Full log attached.
Comment 1 Randy Barlow 2019-04-22 13:46:59 UTC 
It looks like pytest didn't collect a significant number of tests. If you look at the warning output you'll see it listing a list of tests that it didn't collect. I'm not sure why. I'll add this to my todo list.
Comment 2 Fedora Update System 2019-04-22 16:44:00 UTC 
kernel-tools-5.0.9-300.fc30 kernel-headers-5.0.9-300.fc30 kernel-5.0.9-300.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-e84f6c34da
Comment 3 Fedora Update System 2019-04-22 16:45:52 UTC 
kernel-tools-5.0.9-200.fc29 kernel-headers-5.0.9-200.fc29 kernel-5.0.9-200.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1e8a4c6958
Comment 4 Fedora Update System 2019-04-22 16:47:08 UTC 
kernel-tools-5.0.9-100.fc28 kernel-headers-5.0.9-100.fc28 kernel-5.0.9-100.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1b986880ea
Comment 5 Miro Hrončok 2019-04-22 18:15:31 UTC 
Created attachment 1557245 [details]
py.test-3 --collect-only output
Comment 6 Miro Hrončok 2019-04-22 18:18:32 UTC 
> It looks like pytest didn't collect a significant number of tests.

I'm not sure this is true, see bellow:

Python 3.8 in Copr:

FAIL Required test coverage of 97% not reached. Total coverage: 60.64%
================= 1587 passed, 2103 warnings in 269.03 seconds =================

Python 3.7 in the latest Koji build:

Required test coverage of 97% reached. Total coverage: 99.13%
================= 1587 passed, 3758 warnings in 229.42 seconds =================

Yes, there are more warnings. But the number of collected tests is 1587.
Comment 7 Randy Barlow 2019-04-23 14:00:26 UTC 
Yeah you are right. Hmm. I wonder if coverage is not working as expected? I'm not sure I have any other ideas.
Comment 8 Miro Hrončok 2019-04-23 14:10:13 UTC 
https://coverage.readthedocs.io/en/v4.5.x/changes.html 4.5.2 seems important
Comment 9 Miro Hrončok 2019-04-23 15:12:04 UTC 
Yes, this was only bz1544163. Sorry for the noise.
Comment 10 Randy Barlow 2019-04-23 15:43:00 UTC 
Thanks for tracking that down Miro!
Note You need to log in before you can comment on or make changes to this bug.