Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 170296
Summary: | Review Request: qalculate-kde - qt gui frontends to qalculate | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Deji Akingunola <dakingun> | ||||
Component: | Package Review | Assignee: | Paul Howarth <paul> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | fedora-extras-list | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
URL: | http://qalculate.sourceforge.net/ | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-10-17 20:23:45 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 169971 | ||||||
Bug Blocks: | 163779 | ||||||
Attachments: |
|
Description
Deji Akingunola
2005-10-10 16:14:11 UTC
Package have been updated to the new released version, and desktop file installed. ftp://czar.eas.yorku.ca/pub/qalculate/qalculate-kde.spec ftp://czar.eas.yorku.ca/pub/qalculate/qalculate-kde-1.8.2-1.src.rpm. Created attachment 119927 [details] Spec file cleanup First pass (not a full review): URL is actually: ftp://czar.eas.yorku.ca/pub/qalculate/qalculate-kde-0.8.2-1.src.rpm * libqalculate buildreq should be libqalculate-devel, not libqalculate * qt-devel >= 3.0 buildreq is pulled in by kdelibs-devel buildreq (at least for all distros supported by Fedora Extras) * cln-devel, libxml2-devel, glib2-devel buildreqs are pulled in with libqalculate-devel buildreq * explicit Requires: of libqalculate not needed because RPM will generate the library dependency automatically * I think you need to use --disable-rpath with %configure to prevent rpath generation * only one desktop file should be included - use --delete-original with desktop-file-install * why the complexity of a loop in adding the four text files as %doc (as opposed to just having "%doc AUTHORS ChangeLog COPYING TODO" in the files list)? * %clean section missing from spec file * the TODO file is empty and shouldn't be included. Attached patch addresses the above issues. Patched package builds OK in mock and appears to run (and the documentation works too...). Thanks Paul for the patch(es) and review. New files with corrections uploaded. ftp://czar.eas.yorku.ca/pub/qalculate/qalculate-kde.spec ftp://czar.eas.yorku.ca/pub/qalculate/qalculate-kde-0.8.2-2.src.rpm. Review: - rpmlint nearly clean - see below - package and spec file naming OK - package meets guidelines - license is GPL, matches spec, text included - spec file written in English and is legible - sources match upstream - package builds OK in mock for FC4 (i386) - BR's OK - %find_lang used to handle locale data properly - HTML documentation also handled properly - no libraries, pkgconfigs or subpackages to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - docs not excessively large - docs don't affect runtime, except for online help not working if --excludedocs is used - desktop file installed properly - package appears to function correctly - no scriptlets - all previous issues addressed Notes: - rpmlint output: W: qalculate-kde dangling-symlink /usr/share/doc/HTML/en/qalculate_kde/common /usr/share/doc/HTML/en/common W: qalculate-kde symlink-should-be-relative /usr/share/doc/HTML/en/qalculate_kde/common /usr/share/doc/HTML/en/common this is common with KDE apps and has been OK-ed before: http://www.redhat.com/archives/fedora-extras-list/2005-July/msg01495.html Approved. |