Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 170296 - Review Request: qalculate-kde - qt gui frontends to qalculate
Summary: Review Request: qalculate-kde - qt gui frontends to qalculate
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
Depends On: 169971
TreeView+ depends on / blocked
Reported: 2005-10-10 16:14 UTC by Deji Akingunola
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-10-17 20:23:45 UTC
Type: ---

Attachments (Terms of Use)
Spec file cleanup (deleted)
2005-10-13 16:42 UTC, Paul Howarth
no flags Details | Diff

Description Deji Akingunola 2005-10-10 16:14:11 UTC
Spec Name or Url:
SRPM Name or Url:
Description: QT/KDE gui frontends to Qalculate! desktop calculator.

Comment 1 Deji 2005-10-11 16:59:32 UTC
Package have been updated to the new released version, and desktop file installed.

Comment 2 Paul Howarth 2005-10-13 16:42:22 UTC
Created attachment 119927 [details]
Spec file cleanup

First pass (not a full review):

URL is actually:

* libqalculate buildreq should be libqalculate-devel, not libqalculate

* qt-devel >= 3.0 buildreq is pulled in by kdelibs-devel buildreq (at least for
all distros supported by Fedora Extras)

* cln-devel, libxml2-devel, glib2-devel buildreqs are pulled in with
libqalculate-devel buildreq

* explicit Requires: of libqalculate not needed because RPM will generate the
library dependency automatically

* I think you need to use --disable-rpath with %configure to prevent rpath

* only one desktop file should be included - use --delete-original with

* why the complexity of a loop in adding the four text files as %doc (as
opposed to just having "%doc AUTHORS ChangeLog COPYING TODO" in the files

* %clean section missing from spec file

* the TODO file is empty and shouldn't be included.

Attached patch addresses the above issues. Patched package builds OK in mock
and appears to run (and the documentation works too...).

Comment 3 Deji Akingunola 2005-10-13 22:03:13 UTC
Thanks Paul for the patch(es) and review. New files with corrections uploaded.

Comment 4 Paul Howarth 2005-10-14 15:39:57 UTC

- rpmlint nearly clean - see below
- package and spec file naming OK
- package meets guidelines
- license is GPL, matches spec, text included
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock for FC4 (i386)
- BR's OK
- %find_lang used to handle locale data properly
- HTML documentation also handled properly
- no libraries, pkgconfigs or subpackages to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- docs not excessively large
- docs don't affect runtime, except for online help not working if --excludedocs
is used
- desktop file installed properly
- package appears to function correctly
- no scriptlets
- all previous issues addressed


- rpmlint output:
  W: qalculate-kde dangling-symlink /usr/share/doc/HTML/en/qalculate_kde/common
  W: qalculate-kde symlink-should-be-relative
/usr/share/doc/HTML/en/qalculate_kde/common /usr/share/doc/HTML/en/common
  this is common with KDE apps and has been OK-ed before:


Note You need to log in before you can comment on or make changes to this bug.