Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 171046
Summary: | Review Request: gv - A X front-end for the Ghostscript PostScript(TM) interpreter | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
Component: | Package Review | Assignee: | Gérard Milmeister <gemi> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.cora.nwra.com/~orion/fedora/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-12-15 21:37:08 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Orion Poplawski
2005-10-17 17:40:39 UTC
FC4+ only, right? See also http://fedoraproject.org/wiki/Extras/OrphanedPackages and https://bugzilla.redhat.com/bugzilla/buglist.cgi?component=gv&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=MODIFIED (In reply to comment #1) > FC4+ only, right? Yup. This is an orphaned FC3 package, although the spec file is fairly different since it uses the updated GNU source. * Description: leave out the second paragraph * When installing: install-info: warning: no info dir entry in `/usr/share/info/gv.info' you should add "--section" and "--entry" * .desktop file: add "MimeType=application/postscript;" this requires in %post and %postun /usr/bin/update-mime-database /usr/share/mime > /dev/null 2>&1 || : /usr/bin/update-desktop-database /usr/share/applications > /dev/null 2>&1 || : and in Requires(post) and Requires(postun): desktop-file-utils, shared-mime-info http://www.cora.nwra.com/~orion/fedora/gv-3.6.1-2.src.rpm (In reply to comment #3) > * Description: leave out the second paragraph Done. > * When installing: > install-info: warning: no info dir entry in `/usr/share/info/gv.info' > you should add "--section" and "--entry" And what should they be? Sorry, zero experience with install-info. I put in what I thought should go for --entry. That silenced install-info. > * .desktop file: > add "MimeType=application/postscript;" > this requires in %post and %postun > /usr/bin/update-mime-database /usr/share/mime > /dev/null 2>&1 || : > /usr/bin/update-desktop-database /usr/share/applications > /dev/null 2>&1 || : Done. Also added pdf/postscript references where appropriate. > and in Requires(post) and Requires(postun): > desktop-file-utils, shared-mime-info > I required /usr/bin/update-desktop-database and /usr/bin/update-mime-database since I like doing it that way. Thanks for the review! (In reply to comment #4) > > * When installing: > > install-info: warning: no info dir entry in `/usr/share/info/gv.info' > > you should add "--section" and "--entry" > > And what should they be? Sorry, zero experience with install-info. I put in > what I thought should go for --entry. That silenced install-info. Ok, that seems to work out alright. in gv.desktop: "application/pdf" instead of "applicatation/pdf" Maybe there should be a "Comment=" too, this will appear as a tooltip (e.g. "View PostScript and PDF files". "StartupWMClass=GV" does also work, if you want to include it. (In reply to comment #5) > in gv.desktop: > "application/pdf" instead of "applicatation/pdf" > Maybe there should be a "Comment=" too, this will appear as a tooltip (e.g. > "View PostScript and PDF files". > "StartupWMClass=GV" does also work, if you want to include it. > Fixed typo and added the other entries. What does StartupWMClass do? http://www.cora.nwra.com/~orion/fedora/gv-3.6.1-3.src.rpm (In reply to comment #6) What does StartupWMClass do? When starting gv from the menu or icon, this causes some feedback such as a busy cursor until the main window (where the window class in this case is GV) is shown. GNOME programs normally don't need this. Ah. Thanks. Is this approved? APPROVED |