Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 171046 - Review Request: gv - A X front-end for the Ghostscript PostScript(TM) interpreter
Summary: Review Request: gv - A X front-end for the Ghostscript PostScript(TM) interpr...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gérard Milmeister
QA Contact: David Lawrence
URL: http://www.cora.nwra.com/~orion/fedora/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-10-17 17:40 UTC by Orion Poplawski
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-12-15 21:37:08 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Orion Poplawski 2005-10-17 17:40:39 UTC
Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/gv.spec
SRPM Name or Url: http://www.cora.nwra.com/~orion/fedora/gv-3.6.1-1.src.rpm
Description: 

Gv is a user interface for the Ghostscript PostScript(TM) interpreter.
Gv can display PostScript and PDF documents on an X Window System.

Install the gv package if you'd like to view PostScript and PDF
documents on your system.  You'll also need to have the ghostscript
package and X installed.

Comment 2 Orion Poplawski 2005-10-17 19:25:36 UTC
(In reply to comment #1)
> FC4+ only, right?  

Yup.  This is an orphaned FC3 package, although the spec file is fairly
different since it uses the updated GNU source.


Comment 3 Gérard Milmeister 2005-10-20 21:32:18 UTC
* Description: leave out the second paragraph
* When installing: 
  install-info: warning: no info dir entry in `/usr/share/info/gv.info'
  you should add "--section" and "--entry"
* .desktop file:
  add "MimeType=application/postscript;"
  this requires in %post and %postun
  /usr/bin/update-mime-database /usr/share/mime > /dev/null 2>&1 || :
  /usr/bin/update-desktop-database /usr/share/applications > /dev/null 2>&1 || :
  and in Requires(post) and Requires(postun):
  desktop-file-utils, shared-mime-info


Comment 4 Orion Poplawski 2005-10-20 22:14:57 UTC
http://www.cora.nwra.com/~orion/fedora/gv-3.6.1-2.src.rpm

(In reply to comment #3)
> * Description: leave out the second paragraph

Done.

> * When installing: 
>   install-info: warning: no info dir entry in `/usr/share/info/gv.info'
>   you should add "--section" and "--entry"

And what should they be?  Sorry, zero experience with install-info.  I put in
what I thought should go for --entry.  That silenced install-info.

> * .desktop file:
>   add "MimeType=application/postscript;"
>   this requires in %post and %postun
>   /usr/bin/update-mime-database /usr/share/mime > /dev/null 2>&1 || :
>   /usr/bin/update-desktop-database /usr/share/applications > /dev/null 2>&1 || :

Done.  Also added pdf/postscript references where appropriate.

>   and in Requires(post) and Requires(postun):
>   desktop-file-utils, shared-mime-info
> 

I required /usr/bin/update-desktop-database and /usr/bin/update-mime-database
since I like doing it that way.

Thanks for the review!

Comment 5 Gérard Milmeister 2005-10-20 22:47:55 UTC
(In reply to comment #4)

> > * When installing: 
> >   install-info: warning: no info dir entry in `/usr/share/info/gv.info'
> >   you should add "--section" and "--entry"
> 
> And what should they be?  Sorry, zero experience with install-info.  I put in
> what I thought should go for --entry.  That silenced install-info.
Ok, that seems to work out alright.

in gv.desktop:
"application/pdf" instead of "applicatation/pdf"
Maybe there should be a "Comment=" too, this will appear as a tooltip (e.g.
"View PostScript and PDF files".
"StartupWMClass=GV" does also work, if you want to include it.


Comment 6 Orion Poplawski 2005-10-20 23:05:07 UTC
(In reply to comment #5)
> in gv.desktop:
> "application/pdf" instead of "applicatation/pdf"
> Maybe there should be a "Comment=" too, this will appear as a tooltip (e.g.
> "View PostScript and PDF files".
> "StartupWMClass=GV" does also work, if you want to include it.
> 

Fixed typo and added the other entries.  What does StartupWMClass do?

http://www.cora.nwra.com/~orion/fedora/gv-3.6.1-3.src.rpm

Comment 7 Gérard Milmeister 2005-10-21 18:04:20 UTC
(In reply to comment #6)
What does StartupWMClass do?
When starting gv from the menu or icon, this causes some feedback
such as a busy cursor until the main window (where the window class in
this case is GV) is shown.
GNOME programs normally don't need this.

Comment 8 Orion Poplawski 2005-10-21 18:09:19 UTC
Ah. Thanks.  Is this approved?

Comment 9 Gérard Milmeister 2005-10-21 18:31:02 UTC
APPROVED


Note You need to log in before you can comment on or make changes to this bug.