Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 171539
| Summary: | Review Request: kasablanca: Graphical FTP client | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://kasablanca.berlios.de/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-10-22 19:13:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Rex Dieter
2005-10-22 17:30:47 UTC
* Desktop file: the Categories tag should contain Application (wiki: PackagingGuidelines#desktop) * Please remove the CVS tag id on top of the spec file (it mentions kbear.spec) * As in digikamimageplugins : * please drop the debug_package test in make install * please re-add the gtk-update-cache call %changelog
* Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.4.0.2-2
- .desktop: --add-category=Application
- %%post,%%postun: gtk-update-icon-cache
- drop CVS tags
- drop %%{?debug_package}
Spec Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kasablanca-0.4.0.2-2.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kasablanca-0.4.0.2-2.src.rpm
"Application" is not a registered desktop entry category, I wonder if it's still needed in recent distro versions: http://standards.freedesktop.org/menu-spec/latest/apa.html > "Application" is not a registered desktop entry category
It used to, maybe it was removed recently (personally, I considered it mostly
superfluous anyway)
Review for release 2: * RPM name is OK * Source kasablanca-0.4.0.2.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint of kasablanca looks OK * File list of kasablanca looks OK * Works fine. APPROVED |