Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 171539 - Review Request: kasablanca: Graphical FTP client
Summary: Review Request: kasablanca: Graphical FTP client
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
URL: http://kasablanca.berlios.de/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-10-22 17:30 UTC by Rex Dieter
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-10-22 19:13:23 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Rex Dieter 2005-10-22 17:30:47 UTC
Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kasablanca-0.4.0.2-1.spec
SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kasablanca-0.4.0.2-1.src.rpm
Description: 
Kasablanca is an ftp client for KDE, among its features are currently
encryption (auth tls) support, fxp, site bookmarks, and queued transfers.

Comment 1 Aurelien Bompard 2005-10-22 18:11:09 UTC
* Desktop file: the Categories tag should contain Application
  (wiki: PackagingGuidelines#desktop)
* Please remove the CVS tag id on top of the spec file (it mentions kbear.spec)
* As in digikamimageplugins :
  * please drop the debug_package test in make install
  * please re-add the gtk-update-cache call


Comment 2 Rex Dieter 2005-10-22 18:17:01 UTC
%changelog 
* Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.4.0.2-2
- .desktop: --add-category=Application
- %%post,%%postun: gtk-update-icon-cache
- drop CVS tags
- drop %%{?debug_package}

Spec Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kasablanca-0.4.0.2-2.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kasablanca-0.4.0.2-2.src.rpm

Comment 3 Ville Skyttä 2005-10-22 18:34:20 UTC
"Application" is not a registered desktop entry category, I wonder if it's 
still needed in recent distro versions: 
http://standards.freedesktop.org/menu-spec/latest/apa.html 

Comment 4 Rex Dieter 2005-10-22 18:37:35 UTC
> "Application" is not a registered desktop entry category

It used to, maybe it was removed recently (personally, I considered it mostly
superfluous anyway)

Comment 5 Aurelien Bompard 2005-10-22 19:04:07 UTC
Review for release 2:
* RPM name is OK
* Source kasablanca-0.4.0.2.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of kasablanca looks OK
* File list of kasablanca looks OK
* Works fine.
APPROVED



Note You need to log in before you can comment on or make changes to this bug.