Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 173295
| Summary: | Review Request: python-4Suite-XML | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miloslav Trmač <mitr> |
| Component: | Package Review | Assignee: | Ignacio Vazquez-Abrams <ivazqueznet> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list, frank |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://people.redhat.com/mitr/extras/python-4Suite-XML-1.0-0.3.b3.src.rpm | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-01-19 21:39:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Miloslav Trmač
2005-11-16 00:13:23 UTC
What's going to happen about the rest of the 4Suite functionality? 4Suite-1.0b1 ("full") was split upstream, and 4Suite-XML-1.0b2 was released;
upstream wants to "push 4Suite XML to 1.0 and then focus" on the remaining parts
(RDF processing libraries, a XML/RDF repository and a http server).
python-amara in Extras requires the XML libraries, so we need 4Suite-XML;
the other parts will have to be left out until upstream returns to releasing
them.
Core used 4Suite only for the XML libraries in s-c-httpd, which was converted
to use libxslt-python.
hmm. moin in extras can use 4Suite for xslt and docbook parsing for wiki pages. It doesn't have an explicit dep on it, though. thoughts? From a quick look, moin seems to use only the libraries in 4Suite-XML. Updated to 4Suite-XML-1.0b3.
Could I get a sponsor to review the package, please? I'll promise to review
>=3 other packages in return.
- Missing Requires: python-abi = %(%{__python} -c "import sys ; print
sys.version[:3]")
- Doesn't contain any provision for .pyo files
- Hardcoded paths instead of macros (%{_datadir}, %{_libdir})
Thanks, all fixed in http://people.redhat.com/mitr/extras/python-4Suite-XML-1.0-0.2.b3.src.rpm . Nitpicking from an outsider: Summary: Without trailing 's' from 'collections' it looks better, though I'm not an American English speaker. Also I would change Source0 to http://dl.sourceforge.net/foursuite/4Suite-XML-%{ver}.tar.bz2 or ftp://ftp.4suite.org/pub/4Suite/4Suite-XML-%{ver}.tar.bz2 Both fixed in http://people.redhat.com/mitr/extras/python-4Suite-XML-1.0-0.3.b3.src.rpm, thanks. - Are the items in %{_libdir}/4Suite/profiles of any use?
- Consider running %{_libdir}/4Suite/tests/test.py in %check
- I can't find any file or directory called "*profile*" in the built directory,
have I missed anything?
The tarball 4Suite-1.0b3/profile/ files don't look useful:
a) upstream doesn't install them, why should we?
b) at least profile_all.py references "create_document.py" and other test files
which are not present in the tarball
- the test suite fails, so it would just clutter the logs and new failures would
be hidden among the "regular" failures. The test suite was failing in all
4Suite releases I have ever packaged, IIRC.
(In reply to comment #12) > - I can't find any file or directory called "*profile*" in the built directory, > have I missed anything? > The tarball 4Suite-1.0b3/profile/ files don't look useful: > a) upstream doesn't install them, why should we? > b) at least profile_all.py references "create_document.py" and other test files > which are not present in the tarball Interesting. Something in my environment must've caused the install script to create the dir. Oh well, not an big deal. > - the test suite fails, so it would just clutter the logs and new failures would > be hidden among the "regular" failures. The test suite was failing in all > 4Suite releases I have ever packaged, IIRC. Alright, I won't consider this a blocker then. APPROVED |