Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 173295 - Review Request: python-4Suite-XML
Summary: Review Request: python-4Suite-XML
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ignacio Vazquez-Abrams
QA Contact: David Lawrence
URL: http://people.redhat.com/mitr/extras/...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-11-16 00:13 UTC by Miloslav Trmač
Modified: 2014-01-21 22:53 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-01-19 21:39:48 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Miloslav Trmač 2005-11-16 00:13:23 UTC 
Spec Name or Url: http://people.redhat.com/mitr/extras/python-4Suite-XML.spec
SRPM Name or Url: http://people.redhat.com/mitr/extras/python-4Suite-XML-1.0-0.1.b2.src.rpm

4Suite-XML is a suite of Python modules for XML and RDF processing.
Its major components include the following:

 * Ft.Xml.Domlette: A very fast, lightweight XPath-oriented DOM.
 * Ft.Xml.XPath: An XPath 1.0 implementation for Domlette documents.
 * Ft.Xml.Xslt: A robust XSLT 1.0 processor.
 * Ft.Lib: Various support libraries that can be used independently.
---
Misc:
- This is my first Extras package. I already have cvsextras access, nevertheless
  I'd like to be sponsored like anyone else would.
- This package conflicts with 4Suite in Core; 4Suite will be removed from Core
  and replaced by python-4Suite-XML in Extras (which offers only a subset of the
  4Suite functionality).
- The package naming guidelines would suggest python-Ft or something like that,
  but python-4Suite-XML is only one of a family of 4Suite-* packages that should
  eventually use the Ft prefix.
Comment 1 Seth Vidal 2005-11-16 02:05:41 UTC 
What's going to happen about the rest of the 4Suite functionality?
Comment 2 Miloslav Trmač 2005-11-16 02:16:52 UTC 
4Suite-1.0b1 ("full") was split upstream, and 4Suite-XML-1.0b2 was released;
upstream wants to "push 4Suite XML to 1.0 and then focus" on the remaining parts
(RDF processing libraries, a XML/RDF repository and a http server).

python-amara in Extras requires the XML libraries, so we need 4Suite-XML;
the other parts will have to be left out until upstream returns to releasing
them.

Core used 4Suite only for the XML libraries in s-c-httpd, which was converted
to use libxslt-python.
Comment 3 Seth Vidal 2005-11-16 02:21:09 UTC 
hmm. moin in extras can use 4Suite for xslt and docbook parsing for wiki pages.
It doesn't have an explicit dep on it, though.

thoughts?
Comment 4 Miloslav Trmač 2005-11-16 02:30:01 UTC 
From a quick look, moin seems to use only the libraries in 4Suite-XML.
Comment 5 Miloslav Trmač 2005-12-13 19:35:13 UTC 
Updated to 4Suite-XML-1.0b3.

Could I get a sponsor to review the package, please? I'll promise to review
>=3 other packages in return.
Comment 6 Ignacio Vazquez-Abrams 2005-12-27 06:08:11 UTC 
- Missing Requires: python-abi = %(%{__python} -c "import sys ; print
sys.version[:3]")
- Doesn't contain any provision for .pyo files
Comment 7 Ignacio Vazquez-Abrams 2005-12-27 06:29:57 UTC 
- Hardcoded paths instead of macros (%{_datadir}, %{_libdir})
Comment 8 Miloslav Trmač 2006-01-05 19:33:11 UTC 
Thanks, all fixed in
http://people.redhat.com/mitr/extras/python-4Suite-XML-1.0-0.2.b3.src.rpm .
Comment 9 Frank Arnold 2006-01-05 20:37:01 UTC 
Nitpicking from an outsider:

Summary: 
Without trailing 's' from 'collections' it looks better, though I'm not an
American English speaker.

Also I would change Source0 to
http://dl.sourceforge.net/foursuite/4Suite-XML-%{ver}.tar.bz2
or
ftp://ftp.4suite.org/pub/4Suite/4Suite-XML-%{ver}.tar.bz2
Comment 10 Miloslav Trmač 2006-01-06 00:20:15 UTC 
Both fixed in
http://people.redhat.com/mitr/extras/python-4Suite-XML-1.0-0.3.b3.src.rpm, thanks.
Comment 11 Ignacio Vazquez-Abrams 2006-01-08 14:05:46 UTC 
- Are the items in %{_libdir}/4Suite/profiles of any use?
- Consider running %{_libdir}/4Suite/tests/test.py in %check
Comment 12 Miloslav Trmač 2006-01-09 21:04:57 UTC 
- I can't find any file or directory called "*profile*" in the built directory,
  have I missed anything?
  The tarball 4Suite-1.0b3/profile/ files don't look useful:
  a) upstream doesn't install them, why should we?
  b) at least profile_all.py references "create_document.py" and other test files
     which are not present in the tarball
- the test suite fails, so it would just clutter the logs and new failures would
  be hidden among the "regular" failures.  The test suite was failing in all
  4Suite releases I have ever packaged, IIRC.
Comment 13 Ignacio Vazquez-Abrams 2006-01-16 22:33:25 UTC 
(In reply to comment #12)
> - I can't find any file or directory called "*profile*" in the built directory,
>   have I missed anything?
>   The tarball 4Suite-1.0b3/profile/ files don't look useful:
>   a) upstream doesn't install them, why should we?
>   b) at least profile_all.py references "create_document.py" and other test files
>      which are not present in the tarball

Interesting. Something in my environment must've caused the install script to
create the dir. Oh well, not an big deal.

> - the test suite fails, so it would just clutter the logs and new failures would
>   be hidden among the "regular" failures.  The test suite was failing in all
>   4Suite releases I have ever packaged, IIRC.

Alright, I won't consider this a blocker then.

APPROVED
Note You need to log in before you can comment on or make changes to this bug.