Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 173823
| Summary: | Review Request: nuttcp | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Radek Vokál <rvokal> | ||||
| Component: | Package Review | Assignee: | Adrian Reber <adrian> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-extras-list, tcallawa | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://people.redhat.com/rvokal/nuttcp/nuttcp-5.1.11-4.src.rpm | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-11-28 14:52:01 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779, 173744 | ||||||
| Attachments: |
|
||||||
|
Description
Radek Vokál
2005-11-21 17:50:40 UTC
Some packaging changes in http://people.redhat.com/rvokal/nuttcp/nuttcp-5.1.11-2.src.rpm xinted service is installed and unnecessary files from tarball were removed. Will attach a patch with required changes. Created attachment 121340 [details]
spec patch
Changes:
- added a URL
- removed wrong URL from Source
- fixed summary according to guidlines
- removed bogus build require
- disabled xinetd services
- using correct path in xinetd files
- removed unnecessary checks for BUILD_ROOT
- replaced /etc with macro
- added noreplace flag to %config
Ok, I will grab the changes. Why don't you like this? -[ "$RPM_BUILD_ROOT" != "/" ] && rm -fr $RPM_BUILD_ROOT +rm -fr $RPM_BUILD_ROOT I like to double-check things .. -[ "$RPM_BUILD_ROOT" != "/" ] && rm -fr $RPM_BUILD_ROOT +rm -fr $RPM_BUILD_ROOT This has been discussed already many times on the fedora-extras list. As buildroot is already set this makes no sense and what happens if it is /usr /opt // /etc. But the best would be to check mailing list archives for this. point taken, here's patched version http://people.redhat.com/rvokal/nuttcp/nuttcp-5.1.11-3.src.rpm (In reply to comment #5) > -[ "$RPM_BUILD_ROOT" != "/" ] && rm -fr $RPM_BUILD_ROOT > +rm -fr $RPM_BUILD_ROOT > > This has been discussed already many times on the fedora-extras list. > As buildroot is already set this makes no sense and what happens if it is > /usr /opt // /etc. But the best would be to check mailing list archives for this. Would be good to get this into the guidelines then * builds in mock (development and FC4) * clean installation and removal * rpmlint is happy * md5sum of nuttcp-v5.1.11.c matches upstream * spec looks good APPROVED I would like to see a comment above Source0 stating how the tarball was created and that upstream doesn't provide one. Ok, the comment about Source is back. I've also did some gcc clean-up, so now there are only few harmless warnings. http://people.redhat.com/rvokal/nuttcp/nuttcp-5.1.11-4.src.rpm Adrian, I don't have a sponsor, this is my first package in extras. Can you sponsor my account? I would have sponsored you but it looks like I was to slow. Yep, got the sponsor already :) The package is in CVS - devel branch. Closing this as NEXTRELEASE |