Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 173924
Summary: | Review Request: xmlstarlet - command-line XML Swiss army knife | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Paul W. Frields <stickster> |
Component: | Package Review | Assignee: | Ignacio Vazquez-Abrams <ivazqueznet> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, xavier |
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://xmlstar.sourceforge.net/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-11-28 16:45:50 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Paul W. Frields
2005-11-22 18:09:54 UTC
*** Bug 173923 has been marked as a duplicate of this bug. *** In general I think inclusion of xmlstarlet makes sense, Daniel Oops, there was a small snafu between Tommy and me, so please disregard the earlier URLs. Here are the corrected versions: Spec: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet.spec SRPM: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet-1.0.1-1.1.src.rpm Additional fixes to make the command name in the included docs consistent. New versions: Spec: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet.spec SRPM: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet-1.0.1-1.2.src.rpm I'm getting a 403 on the spec file. - Source0 should be http://dl.sourceforge.net/xmlstar/xmlstarlet-%{version}.tar.gz, replacing %{name} in there is optional - Files in %{_mandir} are already marked %doc ! Releases with subreleases (X.Y) might cause problems with the disttag + Upstream source (from proper location) matches + Correct permissions + Builds cleanly in mock + No rpmlint warnings or errors Handled all your comments, Ignacio. Sorry about the spec file mode -- I fixed that as well. I was only using the subreleases for my private packages but I've gone ahead and removed them for this release, now 2%{?dist}. They are available here: Spec: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet.spec SRPM: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet-1.0.1-2.src.rpm Thanks for your prompt review! Ignacio, any chance to look at the revision? Sorry, got distracted for a bit. APPROVED, unless someone else can think of a reason to veto it. Paul, would you mind maintaining an EL5 branch for xmlstarlet ? I can offer to maintain the branch myself if you don't want to. Regards, Xavier I don't mind; the code hasn't changed in a long time and appears to work well everywhere I've used it. (IIRC there's a test suite that runs in the build process.) Package Change Request ====================== Package Name: xmlstarlet New Branches: EL-5 Owners: pfrields cvs done. Thank you Kevin -- tagged, built, and requested for EPEL testing. Xavier, after the next push for EPEL testing you should find the package there. Please take the time to give it a +1 karma in bodhi if everything works for you: https://admin.fedoraproject.org/updates/xmlstarlet |