Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 173979
Summary: | Review Request: Licq - A graphical ICQ Client for Linux | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Vrabec <pvrabec> |
Component: | Package Review | Assignee: | Tomas Mraz <tmraz> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, kevin, yaneti |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://people.redhat.com/pvrabec/rpms/licq-1.3.2-1.src.rpm | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-01-18 15:50:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Peter Vrabec
2005-11-23 12:12:06 UTC
Nobody interested in this? :-( While it doesn't support as many protocols as GAIM, LICQ has its advantages over GAIM, e.g. support for ICQ user-to-user chats. It would be nice to see this back (it was part of Red Hat Linux back in the day) in Extras. If you want, I can: * run the package through the review checklist, * build the package, * run it and report any issues noticed that way. I can't however formally approve the package or sponsor you, we need someone with a higher trust level for that. rpmbuild fails: Processing files: licq-1.3.2-1 error: File not found: /var/tmp/licq-1.3.2-1-root-mraz/usr/share/applnk/Internet/licq.desktop KDEDIR must be set to "/usr" before make install. plugins/qt-gui/share/Makefile must be patched so in the install-data-local target the writability test for $(KDEDIR) is changed to $(DESTDIR)$(KDEDIR) - this should solve the build failure. There are many missing build requires (kde, X) - install mock to find them. In the build process the qt-gui is built twice - with-kde and without, I think it is unnecessary and it clutters the spec file. I have fixed these issues from comment #2. Tomas, could u review the new package. rpmlint licq-1.3.2-1.i386.rpm W: licq no-documentation W: licq dangling-relative-symlink /usr/share/licq/qt-gui/locale/cs.qm cs_CZ.qm The symlink means that the localization of the gui doesn't work, but that's probably some problem with the Makefile. However the documentation should be included - at least the licence must be included (COPYING), but I recommend including other documentation as well. rpmlint licq-kde-1.3.2-1.i386.rpm W: licq-kde non-standard-group Networking/Instant messaging W: licq-kde no-documentation rpmlint licq-osd-1.3.2-1.i386.rpm W: licq-osd non-standard-group Networking/Instant messaging W: licq-osd no-documentation Again the no doc (and licence) problem and also the group should be Applications/Internet probably. fixed, need 4 review Sorry, still not right: rpmlint -v ../RPMS/i386/licq-1.3.2-1.i386.rpm I: licq checking E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/doc/CVS/Root E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/upgrade/CVS/Root E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/upgrade/CVS/Repository E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/doc/CVS/Entries E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/upgrade/CVS/Entries E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/doc/CVS/Repository Please run rpmlint against your built files next time to save your and my time ;-) Note that only relevant doc files should be in the package, not everything. Other problems: - please add LICENSE file to %doc as well. - %{_datadir}/locale/* in files - this is wrong '%find_lang xxxx' must be used with %files -f xxxx.lang'. Also the locale apparently belong to the osd plugin so they should be packaged with it. - read http://fedoraproject.org/wiki/PackagingGuidelines DesktopFiles entry how to cope with the .desktop file - It's also questionable if it should be included within the -kde subpackage or within the main package (I'd prefer that.) - the %post script seems completely bogus to me - the package doesn't own %{_datadir}/licq and %{_libdir}/licq Fixed and checked with rpmlint. I hope licq package is allright now. The desktop file should be installed with desktop-file-install utility and BuildRequires: desktop-file-utils should be added to the .spec. The rest seems to be OK now. OK, .desktop file is installed with desktop-file-install and not via Makefile. Final review: * RPM name is OK * Source licq-1.3.2.tar.bz2 is the same as upstream * This is the latest version * Builds fine * rpmlint looks OK * Works fine Possible improvement: * Tag as %%lang the files /usr/share/licq/qt-gui/locale/*.qm APPROVED Package for devel is now out. Are we going to see an FC4 build of this? That would be nice, FC5 is still 2 months away from now. I'd like to build FC4 branch as soon as possible. |