Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 174278
| Summary: | Review Request: tcldom - XML DOM bindings for Tcl | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Wart <wart> |
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list |
| Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://tclxml.sourceforge.net/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-12-17 06:41:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 169754 | ||
| Bug Blocks: | 163779, 175463 | ||
|
Description
Wart
2005-11-27 07:00:55 UTC
Updated to new upstream sources: http://www.kobold.org/~wart/fedora/tcldom.spec http://www.kobold.org/~wart/fedora/tcldom-3.1-1.src.rpm http://www.kobold.org/~wart/fedora/MD5SUM.asc - package meets naming guidelines
- package meets packaging guidelines
- license (BSD) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- devel requires base package n-v-r
However,
- Have you tested this on 64 bit? %{_libdir} may prove problematic
- BuildRoot should be cleaned at the beginning of %install.
- A bunch of compiler warnings, particularly in tcldomlibxml2.c. Be sure to tell
upstream about this, and show them your patch.
My primary development machine is dual x86_64, and I haven't noticed any build
or runtime problems with %{_libdir}. But I did notice a minor problem loading
the pure-tcl dom library that has been fixed in an updated patch in this next
package.
BuildRoot is now cleaned at the beginning of %install
All patches have been sent upstream, and I've notified the upstream developers
about the compiler warnings. Upstream doesn't release new packages very often,
so I don't expect to see them adopt the patches anytime soon.
New spec file and src rpm:
http://www.kobold.org/~wart/fedora/tcldom.spec
http://www.kobold.org/~wart/fedora/tcldom-3.1-2.src.rpm
Looks good. APPROVED Many thanks for the review! Package Change Request ====================== Package Name: tcldom New Branches: EL-4 EL-5 cvs done. |